mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jozsef Kadlecsik <kadlec@netfilter.org>
To: RubenKelevra <rubenkelevra@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
	netfilter-devel@vger.kernel.org,  coreteam@netfilter.org,
	netdev@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netfilter: ipset: fix typo in hash size macro
Date: Sat, 21 Jun 2025 16:45:09 +0200 (CEST)	[thread overview]
Message-ID: <11f4f9cd-e818-099e-b8b2-782608862eb5@netfilter.org> (raw)
In-Reply-To: <20250620092053.180550-1-rubenkelevra@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1853 bytes --]

Hello,

On Fri, 20 Jun 2025, RubenKelevra wrote:

> Rename IPSET_MIMINAL_HASHSIZE → IPSET_MINIMAL_HASHSIZE in
> ip_set_hash_gen.h, matching the header typo-fix.
> 
> Signed-off-by: RubenKelevra <rubenkelevra@gmail.com>

Patch is applied in the ipset git tree, thank you.

Best regards,
Jozsef
> ---
>  include/linux/netfilter/ipset/ip_set_hash.h | 2 +-
>  net/netfilter/ipset/ip_set_hash_gen.h       | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/netfilter/ipset/ip_set_hash.h b/include/linux/netfilter/ipset/ip_set_hash.h
> index 838abab672af1..56e883661f857 100644
> --- a/include/linux/netfilter/ipset/ip_set_hash.h
> +++ b/include/linux/netfilter/ipset/ip_set_hash.h
> @@ -6,7 +6,7 @@
>  
>  
>  #define IPSET_DEFAULT_HASHSIZE		1024
> -#define IPSET_MIMINAL_HASHSIZE		64
> +#define IPSET_MINIMAL_HASHSIZE		64
>  #define IPSET_DEFAULT_MAXELEM		65536
>  #define IPSET_DEFAULT_PROBES		4
>  #define IPSET_DEFAULT_RESIZE		100
> diff --git a/net/netfilter/ipset/ip_set_hash_gen.h b/net/netfilter/ipset/ip_set_hash_gen.h
> index 5251524b96afa..785d109645fed 100644
> --- a/net/netfilter/ipset/ip_set_hash_gen.h
> +++ b/net/netfilter/ipset/ip_set_hash_gen.h
> @@ -1543,8 +1543,8 @@ IPSET_TOKEN(HTYPE, _create)(struct net *net, struct ip_set *set,
>  
>  	if (tb[IPSET_ATTR_HASHSIZE]) {
>  		hashsize = ip_set_get_h32(tb[IPSET_ATTR_HASHSIZE]);
> -		if (hashsize < IPSET_MIMINAL_HASHSIZE)
> -			hashsize = IPSET_MIMINAL_HASHSIZE;
> +		if (hashsize < IPSET_MINIMAL_HASHSIZE)
> +			hashsize = IPSET_MINIMAL_HASHSIZE;
>  	}
>  
>  	if (tb[IPSET_ATTR_MAXELEM])
> -- 
> 2.49.0
> 
> 

-- 
E-mail : kadlec@netfilter.org, kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.hu
Address: Wigner Research Centre for Physics
         H-1525 Budapest 114, POB. 49, Hungary

      reply	other threads:[~2025-06-21 14:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-19 15:10 RubenKelevra
2025-06-20  6:44 ` Jozsef Kadlecsik
2025-06-20  9:20 ` RubenKelevra
2025-06-21 14:45   ` Jozsef Kadlecsik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11f4f9cd-e818-099e-b8b2-782608862eb5@netfilter.org \
    --to=kadlec@netfilter.org \
    --cc=coreteam@netfilter.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=rubenkelevra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®