From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AE873DDDD7 for ; Thu, 2 Apr 2026 09:49:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775123392; cv=none; b=bBEu+hMwwub39RJBPiGzbqzOFL1XsSuzdhARXwAcKhpw2UAQ11FXLOoxHhpc3Zp2M1XZOMNLFOObYu+WTOMnCOPIKYKxCxu7tOcIYv1UdCXc8VdkdzkqbApX7doXcTPCY1M1W+f1dwegeeAKGG2t+PTTmOA66F/OiHnW8NV5D2w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775123392; c=relaxed/simple; bh=nJvoCWu38hxxnKheIDRJrRL9Wcq5XBQkqaSCt/hgYvA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NNd8tFTb4EckOf0k9ykIctOeKzQndhIK+E6iWXyQNFDO6zn9FDgf6at4FD//qeNTBfAKJjFQZhkkJdiBOSaN8ttkvS691UG1pj327e46QszSEKg0Dh0AnoD6THcgKksoaPRjJTDy9GlrDDHex4CzomGh1D6DMuLUQBE1XBOtC2M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WnsfDuih; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WnsfDuih" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-43cf7683a28so413517f8f.2 for ; Thu, 02 Apr 2026 02:49:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1775123388; x=1775728188; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rEH5WzWrgYk3Nyry0RXufGI5C4aPoskx4NXm70qvdmI=; b=WnsfDuihaYGATbi0l46ldZIQfaM4X+pNgJC2HO+4jFJkZwhaNjXpOBetNL/d2KWRnN JVwv+kzdQHeiuiXozmOfy4mWhppRUkxaon8XBGkSBXtNxo6uIVkl8uUZm/1GUlK30e6w +nA409ypcgseQPa/DBomaQDZHoUzw1CNpWWYX/arsF4fy/VnxaRsDZWhNriityndjm4a ePkX5poU4d+D4EeqqEfOKi9/6p3DYWtbGFbuqBE/3/FVIZiuHcWzDcZJ4ijVyZ/NMaDh Td3S7C80U3CzG2/Z5S5OthlqsKhgq1r5AkyVYmM5iLohzKexGol7TFIUyskHLuGBiMUy dTJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775123388; x=1775728188; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rEH5WzWrgYk3Nyry0RXufGI5C4aPoskx4NXm70qvdmI=; b=awA85DGtTNnF0HPfDaNKk7ofhhbM2JjR/i1LTr3kDQN3dDb4KnWXOSJRym+8lE/0Fd yvw0uwWc1DBOluWjebFDuroYwPxcwXWK6CYUItsCWs3GBQDfrpFcZluVFh6DcGXhw+9Y FBc37Jst/ADOjafrCAWPbd3Eqn1LV+VYC+9KFkPW7ODQiMMYj0gQPYBdHKznRXMFVQ2+ 11trAj8v5PpzgIVI3hbzER+i8PstwpnPHq505V0sldt+O5XlB4JYabQaocMjv7PBEHws H2ypZY6Svu+yRBpPSKyVs1ajpMbUaoBam/CbmK9QMSvQqvUlcU09hwO3uNA1ONhHXYSC gerg== X-Forwarded-Encrypted: i=1; AJvYcCWLYNWgf3XIZ5ebCm7woUbhfJFeQdhXiZnqI/ClQF7jXOOVCx9HnBpTWMApzVjzM/gpF4VabXyvxF1cAHU=@vger.kernel.org X-Gm-Message-State: AOJu0YxztWld/HNqmv6u5BDICaFr3F/Uki9t7SS5BpvfgM2Tq/t1cx3A 57T81wr3nMi51AwqZG5xT8tLjbp4FmwuDLLtf1wkqvbKBPMZ2FFjJIAaGZR9E1OLFIM= X-Gm-Gg: AeBDietbQgmsmIw4s8InF+ELMGTTG74NzToeBMi2/y4SNOx+cEkckD0KSqQ05PhP+aH +m5OQcb/e08x9wr0TULfc4P7GQCCL2d1UEWlY04wIunbTG8JzR3ZLjPkrfJfCMs8ZNDx+GPFUu8 H1IJaUXYiuU1bzpaWeUBE0FTfK373Vo5QqZbxP9taJbtxvWxhDwYRezx9I9FOFuQTRu1pmk6hqn y5rCJKX5bSMHpK6/q1z5hy0hjRbiMEVx0sYPACN/qRpSuSHgaCgxRnzzFzV6hfAN54NiErshjXA BDIHpZoPPGeqNtXeS5/ns5fnEI88ok8X6xs+bWT8R83PZHL5ecuej4+HFrskPFzT2A4wkyKdbS4 qMCpuDBA7k13xMifFxyG5bIDsov31sjDitUth6Mb80sA704glo9+PDn/ykuvGnCZPmU4Peaxp3I pTOcJqeyCaXcLAvZfqNQgYLTo+Gurt X-Received: by 2002:adf:eac1:0:b0:43d:1c49:ce35 with SMTP id ffacd0b85a97d-43d1c49ce84mr6224854f8f.3.1775123387496; Thu, 02 Apr 2026 02:49:47 -0700 (PDT) Received: from [192.168.1.3] ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e2a6f13sm6644433f8f.3.2026.04.02.02.49.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Apr 2026 02:49:47 -0700 (PDT) Message-ID: <11fd32e8-07e1-4889-bd02-5eb38b7e1ed1@linaro.org> Date: Thu, 2 Apr 2026 10:49:45 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] perf arm_spe: Decode Arm N1 IMPDEF events To: Leo Yan Cc: John Garry , Will Deacon , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Al Grant , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260401-james-spe-impdef-decode-v1-0-ad0d372c220c@linaro.org> <20260401-james-spe-impdef-decode-v1-3-ad0d372c220c@linaro.org> <20260402093234.GG356832@e132581.arm.com> Content-Language: en-US From: James Clark In-Reply-To: <20260402093234.GG356832@e132581.arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02/04/2026 10:32 am, Leo Yan wrote: > On Wed, Apr 01, 2026 at 03:25:51PM +0100, James Clark wrote: > > [...] > >> static int arm_spe_pkt_desc_event(const struct arm_spe_pkt *packet, >> - char *buf, size_t buf_len) >> + char *buf, size_t buf_len, u64 midr) > > Just wandering if we can add a "midr" field into struct arm_spe_pkt ? > Then we don't need to change many functions for populating midr. > > The rest is good for me. > > Thanks, > Leo Yeah I can do that. I was worried they were stored in an array and it would be a waste of space, but they're not so it's ok.