From: Tianrui Zhao <zhaotianrui@loongson.cn>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Mark Brown <broonie@kernel.org>,
Alex Deucher <alexander.deucher@amd.com>,
Oliver Upton <oliver.upton@linux.dev>,
maobibo@loongson.cn, Xi Ruoyao <xry111@xry111.site>
Subject: Re: [PING PATCH v4 27/29] LoongArch: KVM: Implement vcpu world switch
Date: Thu, 30 Mar 2023 11:41:35 +0800 [thread overview]
Message-ID: <11fefc2b-63e4-a4a8-94c7-c4e312aa4958@loongson.cn> (raw)
In-Reply-To: <55c79f33-2549-38eb-f868-8e6141d7d322@redhat.com>
在 2023年03月28日 22:13, Paolo Bonzini 写道:
> On 3/28/23 14:31, Tianrui Zhao wrote:
>> + * prepare switch to guest
>> + * @param:
>> + * KVM_ARCH: kvm_vcpu_arch, don't touch it until 'ertn'
>> + * GPRNUM: KVM_ARCH gpr number
>
> Stale comment (should be "a2: kvm_vcpu_arch, don't touch it until
> 'ertn'").
>
> Since you are at it, I noticed now that tmp and tmp1 aren't too useful
> because all registers will be overwritten before the end of the macro.
> You choose whether to keep or remove them.
>
> Paolo
Thanks, I will fix the stale comment and remove the tmp,tmp1 argument
and replace it with t0,t1 reg.
Thanks
Tianrui Zhao
>
>> + * tmp, tmp1: temp register
>> + */
next prev parent reply other threads:[~2023-03-30 3:41 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 12:30 [PING PATCH v4 00/29] Add KVM LoongArch support Tianrui Zhao
2023-03-28 12:30 ` [PING PATCH v4 01/29] LoongArch: KVM: Add kvm related header files Tianrui Zhao
2023-03-28 12:30 ` [PING PATCH v4 02/29] LoongArch: KVM: Implement kvm module related interface Tianrui Zhao
2023-03-28 12:30 ` [PING PATCH v4 03/29] LoongArch: KVM: Implement kvm hardware enable, disable interface Tianrui Zhao
2023-03-28 12:30 ` [PING PATCH v4 04/29] LoongArch: KVM: Implement VM related functions Tianrui Zhao
2023-03-28 12:30 ` [PING PATCH v4 05/29] LoongArch: KVM: Add vcpu related header files Tianrui Zhao
2023-03-28 12:30 ` [PING PATCH v4 06/29] LoongArch: KVM: Implement vcpu create and destroy interface Tianrui Zhao
2023-03-28 12:30 ` [PING PATCH v4 07/29] LoongArch: KVM: Implement vcpu run interface Tianrui Zhao
2023-03-28 12:30 ` [PING PATCH v4 08/29] LoongArch: KVM: Implement vcpu handle exit interface Tianrui Zhao
2023-03-28 12:30 ` [PING PATCH v4 09/29] LoongArch: KVM: Implement vcpu get, vcpu set registers Tianrui Zhao
2023-03-28 12:31 ` [PING PATCH v4 10/29] LoongArch: KVM: Implement vcpu ENABLE_CAP ioctl interface Tianrui Zhao
2023-03-28 12:31 ` [PING PATCH v4 11/29] LoongArch: KVM: Implement fpu related operations for vcpu Tianrui Zhao
2023-03-28 12:31 ` [PING PATCH v4 12/29] LoongArch: KVM: Implement vcpu interrupt operations Tianrui Zhao
2023-03-28 12:31 ` [PING PATCH v4 13/29] LoongArch: KVM: Implement misc vcpu related interfaces Tianrui Zhao
2023-03-28 12:31 ` [PING PATCH v4 14/29] LoongArch: KVM: Implement vcpu load and vcpu put operations Tianrui Zhao
2023-03-28 12:31 ` [PING PATCH v4 15/29] LoongArch: KVM: Implement vcpu status description Tianrui Zhao
2023-03-28 12:31 ` [PING PATCH v4 16/29] LoongArch: KVM: Implement update VM id function Tianrui Zhao
2023-03-28 12:31 ` [PING PATCH v4 17/29] LoongArch: KVM: Implement virtual machine tlb operations Tianrui Zhao
2023-03-28 12:31 ` [PING PATCH v4 18/29] LoongArch: KVM: Implement vcpu timer operations Tianrui Zhao
2023-03-28 12:31 ` [PING PATCH v4 19/29] LoongArch: KVM: Implement kvm mmu operations Tianrui Zhao
2023-03-28 12:31 ` [PING PATCH v4 20/29] LoongArch: KVM: Implement handle csr excption Tianrui Zhao
2023-03-28 12:31 ` [PING PATCH v4 21/29] LoongArch: KVM: Implement handle iocsr exception Tianrui Zhao
2023-03-28 12:31 ` [PING PATCH v4 22/29] LoongArch: KVM: Implement handle idle exception Tianrui Zhao
2023-03-28 12:31 ` [PING PATCH v4 23/29] LoongArch: KVM: Implement handle gspr exception Tianrui Zhao
2023-03-28 14:13 ` Paolo Bonzini
2023-03-28 12:31 ` [PING PATCH v4 24/29] LoongArch: KVM: Implement handle mmio exception Tianrui Zhao
2023-03-28 12:31 ` [PING PATCH v4 25/29] LoongArch: KVM: Implement handle fpu exception Tianrui Zhao
2023-03-28 12:31 ` [PING PATCH v4 26/29] LoongArch: KVM: Implement kvm exception vector Tianrui Zhao
2023-03-28 12:31 ` [PING PATCH v4 27/29] LoongArch: KVM: Implement vcpu world switch Tianrui Zhao
2023-03-28 14:13 ` Paolo Bonzini
2023-03-30 3:41 ` Tianrui Zhao [this message]
2023-03-28 12:31 ` [PING PATCH v4 28/29] LoongArch: KVM: Implement probe virtualization when loongarch cpu init Tianrui Zhao
2023-03-28 12:31 ` [PING PATCH v4 29/29] LoongArch: KVM: Enable kvm config and add the makefile Tianrui Zhao
2023-03-28 14:16 ` [PING PATCH v4 00/29] Add KVM LoongArch support Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11fefc2b-63e4-a4a8-94c7-c4e312aa4958@loongson.cn \
--to=zhaotianrui@loongson.cn \
--cc=alexander.deucher@amd.com \
--cc=axboe@kernel.dk \
--cc=broonie@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@xen0n.name \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=maobibo@loongson.cn \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®