From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F6F1C282E1 for ; Thu, 23 May 2019 12:02:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0EECF21019 for ; Thu, 23 May 2019 12:02:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="mYh3up+P" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730529AbfEWMCK (ORCPT ); Thu, 23 May 2019 08:02:10 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:9815 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728309AbfEWMCJ (ORCPT ); Thu, 23 May 2019 08:02:09 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 458p5V4Lx7z9v2NT; Thu, 23 May 2019 14:02:06 +0200 (CEST) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=mYh3up+P; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id t0X21tqOHZa6; Thu, 23 May 2019 14:02:06 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 458p5V2pLmz9v2NS; Thu, 23 May 2019 14:02:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1558612926; bh=dxjR5/OUEbuHjryrELjiCz2BmB568YPeDBsdsR3B27c=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=mYh3up+PAV5q1CkXEn+MOv/nsPx6DdMICOFeThJ9qrLIPZA+jhtbkBC+HHc9/cL0A hZ2n1Zjj7fl/dhUGlc8qA57UwniCg+wLUPsvmBPHhgH6vGW6sFn8oCHfLDVYRlxTco ll+LSYtlKlkVUYiJJDsANgkM8wdmay41mIKPj+do= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 9C6A68B860; Thu, 23 May 2019 14:02:07 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id r1aNl5ZvA7nM; Thu, 23 May 2019 14:02:07 +0200 (CEST) Received: from PO15451 (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 895C78B858; Thu, 23 May 2019 14:02:06 +0200 (CEST) Subject: Re: [PATCH] powerpc/power: Expose pfn_is_nosave prototype To: Mathieu Malaterre , Michael Ellerman Cc: Len Brown , linux-pm@vger.kernel.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Paul Mackerras , Pavel Machek , linuxppc-dev@lists.ozlabs.org References: <20190523114736.30268-1-malat@debian.org> From: Christophe Leroy Message-ID: <11ffdbd5-60a9-b1fa-aa83-9d3c60e3d462@c-s.fr> Date: Thu, 23 May 2019 14:02:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190523114736.30268-1-malat@debian.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 23/05/2019 à 13:47, Mathieu Malaterre a écrit : > The declaration for pfn_is_nosave is only available in > kernel/power/power.h. Since this function can be override in arch, > expose it globally. Having a prototype will make sure to avoid warning > (sometime treated as error with W=1) such as: > > arch/powerpc/kernel/suspend.c:18:5: error: no previous prototype for 'pfn_is_nosave' [-Werror=missing-prototypes] > > This moves the declaration into a globally visible header file and add > missing include to avoid a warning in powerpc. Then you should also drop it from kernel/power/power.h and arch/s390/kernel/entry.h Christophe > > Signed-off-by: Mathieu Malaterre > --- > arch/powerpc/kernel/suspend.c | 1 + > include/linux/suspend.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/arch/powerpc/kernel/suspend.c b/arch/powerpc/kernel/suspend.c > index a531154cc0f3..9e1b6b894245 100644 > --- a/arch/powerpc/kernel/suspend.c > +++ b/arch/powerpc/kernel/suspend.c > @@ -8,6 +8,7 @@ > */ > > #include > +#include > #include > #include > > diff --git a/include/linux/suspend.h b/include/linux/suspend.h > index 3f529ad9a9d2..2660bbdf5230 100644 > --- a/include/linux/suspend.h > +++ b/include/linux/suspend.h > @@ -395,6 +395,7 @@ extern bool system_entering_hibernation(void); > extern bool hibernation_available(void); > asmlinkage int swsusp_save(void); > extern struct pbe *restore_pblist; > +int pfn_is_nosave(unsigned long pfn); > #else /* CONFIG_HIBERNATION */ > static inline void register_nosave_region(unsigned long b, unsigned long e) {} > static inline void register_nosave_region_late(unsigned long b, unsigned long e) {} >