From: Daniel Walker <dwalker@mvista.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Maxim Levitsky <maximlevitsky@gmail.com>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH] fix wrong sized spinlock flags argument
Date: Thu, 17 Jan 2008 16:05:06 -0800 [thread overview]
Message-ID: <1200614706.18731.170.camel@imap.mvista.com> (raw)
In-Reply-To: <alpine.LFD.1.00.0801171542390.2957@woody.linux-foundation.org>
On Thu, 2008-01-17 at 15:48 -0800, Linus Torvalds wrote:
> Applied.
>
> However, the patch itself didn't apply cleanly, because in my souce tree,
> these two lines are in a different order:
>
> On Thu, 17 Jan 2008, Daniel Walker wrote:
> >
> > pci_set_power_state(pci_dev, PCI_D0);
> > pci_restore_state(pci_dev);
>
> but I actually think your order is the *correct* one (because I'm not at
> all sure that config space writes are even guaranteed to make a difference
> when in D3cold).
I was actually using 2.6.24-rc8-mm1 . The code looked similar enough,
but I must have overlooked the fact that the lines above got switched..
Daniel
next prev parent reply other threads:[~2008-01-18 0:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-17 20:52 Daniel Walker
2008-01-17 23:48 ` Linus Torvalds
2008-01-18 0:05 ` Daniel Walker [this message]
2008-01-18 10:13 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200614706.18731.170.camel@imap.mvista.com \
--to=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=mchehab@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®