mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Glauber de Oliveira Costa <gcosta@redhat.com>
To: lguest@ozlabs.org
Cc: glommer@gmail.com, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, rusty@rustcorp.com.au,
	rostedt@goodmis.org
Subject: [PATCH 0/7] More lguest massage.
Date: Thu, 17 Jan 2008 22:35:46 -0200	[thread overview]
Message-ID: <12006165651341-git-send-email-gcosta@redhat.com> (raw)
In-Reply-To: <1200616561270-git-send-email-gcosta@redhat.com>

inour new model, pages are assigned to a virtual cpu, not to a guest.
Wemove it to the lg_cpu structure.

Signed-off-by:Glauber de Oliveira Costa <gcosta@redhat.com>
---
drivers/lguest/lg.h          |    3 ++-
drivers/lguest/lguest_user.c |    8 ++++----
drivers/lguest/x86/core.c    |    4 ++--
3 files changed, 8 insertions(+), 7 deletions(-)

diff--git a/drivers/lguest/lg.h b/drivers/lguest/lg.h
index11a3ae2..eb473a5 100644
---a/drivers/lguest/lg.h
+++b/drivers/lguest/lg.h
@@-57,6 +57,8 @@ struct lg_cpu {
	unsigned long regs_page;
	struct lguest_regs *regs;

+	structlguest_pages *last_pages;
+
	int cpu_pgd; /* which pgd this cpu is currently using */

	/* If a hypercall was asked for, this points to the arguments. */
@@-92,7 +94,6 @@ struct lguest

	/* Bitmap of what has changed: see CHANGED_* above. */
	int changed;
-	structlguest_pages *last_pages;

	struct pgdir pgdirs[4];

diff--git a/drivers/lguest/lguest_user.c b/drivers/lguest/lguest_user.c
indexf4f6df8..a87fca6 100644
---a/drivers/lguest/lguest_user.c
+++b/drivers/lguest/lguest_user.c
@@-131,6 +131,10 @@ static int lg_cpu_start(struct lg_cpu *cpu, unsigned id, unsigned long start_ip)
	 * reference, it is destroyed before close() is called. */
	cpu->mm = get_task_mm(cpu->tsk);

+	/*We remember which CPU's pages this Guest used last, for optimization
+	* when the same Guest runs on the same CPU twice. */
+	cpu->last_pages= NULL;
+
	return 0;
}

@@-192,10 +196,6 @@ static int initialize(struct file *file, const unsigned long __user *input)
	if (err)
		goto free_regs;

-	/*We remember which CPU's pages this Guest used last, for optimization
-	* when the same Guest runs on the same CPU twice. */
-	lg->last_pages= NULL;
-
	/* We keep our "struct lguest" in the file's private_data. */
	file->private_data = lg;

diff--git a/drivers/lguest/x86/core.c b/drivers/lguest/x86/core.c
index25f48fd..3e457f2 100644
---a/drivers/lguest/x86/core.c
+++b/drivers/lguest/x86/core.c
@@-80,9 +80,9 @@ static void copy_in_guest_info(struct lg_cpu *cpu, struct lguest_pages *pages)
	 * same Guest we ran last time (and that Guest hasn't run anywhere else
	 * meanwhile).  If that's not the case, we pretend everything in the
	 * Guest has changed. */
-	if(__get_cpu_var(last_cpu) != cpu || lg->last_pages != pages) {
+	if(__get_cpu_var(last_cpu) != cpu || cpu->last_pages != pages) {
		__get_cpu_var(last_cpu) = cpu;
-		lg->last_pages= pages;
+		cpu->last_pages= pages;
		lg->changed = CHANGED_ALL;
	}

--
1.5.0.6


  reply	other threads:[~2008-01-18  0:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-18  0:35 Glauber de Oliveira Costa
2008-01-18  0:35 ` Glauber de Oliveira Costa
2008-01-18  0:35   ` Glauber de Oliveira Costa
2008-01-18  0:35     ` Glauber de Oliveira Costa [this message]
2008-01-18  0:35       ` Glauber de Oliveira Costa
2008-01-18  0:35         ` Glauber de Oliveira Costa
2008-01-18  0:35           ` Glauber de Oliveira Costa
2008-01-18  0:35             ` Glauber de Oliveira Costa
2008-01-18  1:02               ` Glauber de Oliveira Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12006165651341-git-send-email-gcosta@redhat.com \
    --to=gcosta@redhat.com \
    --cc=glommer@gmail.com \
    --cc=lguest@ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®