mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: "Rafał Miłecki" <zajec5@gmail.com>,
	"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>
Cc: "Tom Rini" <trini@konsulko.com>,
	linux-arm-kernel@lists.infradead.org, u-boot@lists.denx.de,
	linux-kernel@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>,
	"kernel test robot" <lkp@intel.com>
Subject: Re: [PATCH] nvmem: u-boot-env: fix crc32 casting type
Date: Mon, 29 Aug 2022 08:25:58 +0200	[thread overview]
Message-ID: <1200fe58-72de-5372-a0f0-2ac93b6aeccc@pengutronix.de> (raw)
In-Reply-To: <20220818043837.28698-1-zajec5@gmail.com>

Hello Rafał,

On 18.08.22 06:38, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This fixes:
> drivers/nvmem/u-boot-env.c:141:17: sparse: sparse: cast to restricted __le32
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: f955dc1445069 ("nvmem: add driver handling U-Boot environment variables")
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>  drivers/nvmem/u-boot-env.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvmem/u-boot-env.c b/drivers/nvmem/u-boot-env.c
> index 9b9abfb8f187..fb993ef4249f 100644
> --- a/drivers/nvmem/u-boot-env.c
> +++ b/drivers/nvmem/u-boot-env.c
> @@ -138,7 +138,7 @@ static int u_boot_env_parse(struct u_boot_env *priv)
>  		data_offset = offsetof(struct u_boot_env_image_redundant, data);
>  		break;
>  	}
> -	crc32 = le32_to_cpu(*(uint32_t *)(buf + crc32_offset));
> +	crc32 = le32_to_cpu(*(__le32 *)(buf + crc32_offset));

I had to do a double take to make sure alignment is not violated.
It's not, because crc32_offset is always zero.

How about rewriting this as

  /* CRC32 is always at offset 0 */
  crc32 = le32_to_cpup(buf);

To make the alignment clear to the reader?

>  	crc32_data_len = priv->mtd->size - crc32_data_offset;
>  	data_len = priv->mtd->size - data_offset;
>  

Cheers,
Ahmad

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

      reply	other threads:[~2022-08-29  6:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-18  4:38 Rafał Miłecki
2022-08-29  6:25 ` Ahmad Fatoum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1200fe58-72de-5372-a0f0-2ac93b6aeccc@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=rafal@milecki.pl \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®