From: Tom Lendacky <thomas.lendacky@amd.com>
To: Ard Biesheuvel <ardb@kernel.org>, Arnd Bergmann <arnd@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
X86 ML <x86@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/efi: select ARCH_USE_MEMREMAP_PROT
Date: Sun, 5 Dec 2021 09:15:15 -0600 [thread overview]
Message-ID: <120102a7-3c03-ce36-198c-f60f059a6cf9@amd.com> (raw)
In-Reply-To: <CAMj1kXGj=AGp6im71+OETHGSCat0mQfOf7FcDdyKwxFEBubzdw@mail.gmail.com>
On 12/4/21 11:55 AM, Ard Biesheuvel wrote:
> On Sat, 4 Dec 2021 at 18:42, Arnd Bergmann <arnd@kernel.org> wrote:
>>
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The patch to map the EFI memmap as encrypted introduces a
>> link failure in configurations without encryption support:
>>
>> x86_64-linux-ld: arch/x86/platform/efi/quirks.o: in function `efi_arch_mem_reserve':
>> quirks.c:(.init.text+0x127): undefined reference to `early_memremap_prot'
>>
>> Select the necessary symbol here as well to fix the build.
>>
>> Fixes: 8f1dd76c9b55 ("x86/sme: Explicitly map new EFI memmap table as encrypted")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Thanks for the report. I'll fold this fix into the original patch instead.
Thanks Arnd and Ard!
Tom
>
>> ---
>> arch/x86/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>> index 05362527f6b5..93befe25d787 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -1934,6 +1934,7 @@ config EFI
>> depends on ACPI
>> select UCS2_STRING
>> select EFI_RUNTIME_WRAPPERS
>> + select ARCH_USE_MEMREMAP_PROT
>> help
>> This enables the kernel to use EFI runtime services that are
>> available (such as the EFI variable services).
>> --
>> 2.29.2
>>
prev parent reply other threads:[~2021-12-05 15:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 17:41 Arnd Bergmann
2021-12-04 17:55 ` Ard Biesheuvel
2021-12-05 15:15 ` Tom Lendacky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=120102a7-3c03-ce36-198c-f60f059a6cf9@amd.com \
--to=thomas.lendacky@amd.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®