From: Shaohua Li <shaohua.li@intel.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, clameter <clameter@sgi.com>
Subject: [RFC] some page can't be migrated
Date: Wed, 23 Jan 2008 14:22:37 +0800 [thread overview]
Message-ID: <1201069357.32059.13.camel@sli10-desk.sh.intel.com> (raw)
Anonymous page might have fs-private metadata, the page is truncated. As
the page hasn't mapping, page migration refuse to migrate the page. It
appears the page is only freed in page reclaim and if zone watermark is
low, the page is never freed, as a result migration always fail. I
thought we could free the metadata so such page can be freed in
migration and make migration more reliable?
Thanks,
Shaohua
diff --git a/mm/migrate.c b/mm/migrate.c
index 6a207e8..6bc38f7 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -633,6 +633,17 @@ static int unmap_and_move(new_page_t get_new_page, unsigned long private,
goto unlock;
wait_on_page_writeback(page);
}
+
+ /*
+ * See truncate_complete_page(). Anonymous page might have
+ * fs-private metadata, the page is truncated. Such page can't be
+ * migrated. Try to free metadata, so the page can be freed.
+ */
+ if (!page->mapping && !PageAnon(page) && PagePrivate(page)) {
+ try_to_release_page(page, GFP_KERNEL);
+ goto unlock;
+ }
+
/*
* By try_to_unmap(), page->mapcount goes down to 0 here. In this case,
* we cannot notice that anon_vma is freed while we migrates a page.
next reply other threads:[~2008-01-23 6:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 6:22 Shaohua Li [this message]
2008-01-25 3:03 ` Nick Piggin
2008-01-25 3:09 ` Christoph Lameter
2008-01-25 3:09 ` Shaohua Li
2008-01-25 3:12 ` Christoph Lameter
2008-01-25 3:18 ` Shaohua Li
2008-01-25 5:20 ` Nick Piggin
2008-01-25 3:37 ` Christoph Lameter
2008-01-25 3:59 ` Shaohua Li
2008-01-25 4:01 ` Christoph Lameter
2008-01-25 4:17 ` Nick Piggin
2008-01-25 4:42 ` Christoph Lameter
2008-01-25 6:03 ` Shaohua Li
2008-01-27 6:03 ` Andrew Morton
2008-01-28 1:43 ` Nick Piggin
2008-01-28 1:48 ` Shaohua Li
2008-01-28 19:09 ` Christoph Lameter
2008-01-28 23:17 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201069357.32059.13.camel@sli10-desk.sh.intel.com \
--to=shaohua.li@intel.com \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®