mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
To: trivial@kernel.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, tigran@aivazian.fsnet.co.uk
Subject: [PATCH 5/9] bfs: move function prototype to the proper header file
Date: Fri, 25 Jan 2008 01:32:04 +0300	[thread overview]
Message-ID: <1201213928-18183-6-git-send-email-dmitri.vorobiev@gmail.com> (raw)
In-Reply-To: <1201213928-18183-1-git-send-email-dmitri.vorobiev@gmail.com>

The dump_imap() routine is defined in bs/bfs/inode.c and used both in
the same file and in fs/bfs/dir.c. This patch adds an extern function
declaration to the private bfs.h header file.

The effect is that one warning issued by checkpatch.pl is gone.

Before the patch:

$ ./scripts/checkpatch.pl --file  fs/bfs/dir.c | grep total
total: 0 errors, 1 warnings, 370 lines checked

After the patch:

$ ./scripts/checkpatch.pl --file  fs/bfs/dir.c | grep total
total: 0 errors, 0 warnings, 368 lines checked

This patch was compile-tested by building the BFS driver both
as a module and as a part of the kernel proper.

Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
---
 fs/bfs/bfs.h   |    3 +++
 fs/bfs/dir.c   |    2 --
 fs/bfs/inode.c |    2 --
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/fs/bfs/bfs.h b/fs/bfs/bfs.h
index 090b96e..ecc74bb 100644
--- a/fs/bfs/bfs.h
+++ b/fs/bfs/bfs.h
@@ -54,4 +54,7 @@ extern const struct address_space_operations bfs_aops;
 extern const struct inode_operations bfs_dir_inops;
 extern const struct file_operations bfs_dir_operations;
 
+/* inode.c */
+extern void dump_imap(const char *, struct super_block *);
+
 #endif /* _FS_BFS_BFS_H */
diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c
index 5462a5b..2964505 100644
--- a/fs/bfs/dir.c
+++ b/fs/bfs/dir.c
@@ -81,8 +81,6 @@ const struct file_operations bfs_dir_operations = {
 	.fsync		= file_fsync,
 };
 
-extern void dump_imap(const char *, struct super_block *);
-
 static int bfs_create(struct inode *dir, struct dentry *dentry, int mode,
 						struct nameidata *nd)
 {
diff --git a/fs/bfs/inode.c b/fs/bfs/inode.c
index 5191990..91d5686 100644
--- a/fs/bfs/inode.c
+++ b/fs/bfs/inode.c
@@ -30,8 +30,6 @@ MODULE_LICENSE("GPL");
 #define dprintf(x...)
 #endif
 
-void dump_imap(const char *prefix, struct super_block *s);
-
 static void bfs_read_inode(struct inode *inode)
 {
 	unsigned long ino = inode->i_ino;
-- 
1.5.3


  parent reply	other threads:[~2008-01-24 22:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-24 22:31 [PATCH 0/9] bfs: assorted cleanups Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 1/9] bfs: remove a useless variable Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 2/9] bfs: coding style cleanup in fs/bfs/inode.c Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 3/9] bfs: coding style cleanup in fs/bfs/bfs.h Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 4/9] bfs: coding style cleanup in fs/bfs/dir.c Dmitri Vorobiev
2008-01-24 22:32 ` Dmitri Vorobiev [this message]
2008-01-24 22:50   ` [PATCH 5/9] bfs: move function prototype to the proper header file Heikki Orsila
2008-01-24 23:08     ` Tigran Aivazian
2008-01-24 23:17       ` Tigran Aivazian
2008-01-24 23:13     ` Dmitri Vorobiev
2008-01-24 23:22       ` Tigran Aivazian
2008-01-24 23:30         ` Dmitri Vorobiev
2008-01-25 10:42         ` Adrian Bunk
2008-01-25 11:12           ` Dmitri Vorobiev
2008-01-24 23:33       ` Heikki Orsila
2008-01-24 23:47         ` Dmitri Vorobiev
2008-01-25  1:55       ` Kyle Moffett
2008-01-24 22:32 ` [PATCH 6/9] bfs: coding style cleanup in fs/bfs/file.c Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 7/9] bfs: coding style cleanup in include/linux/bfs_fs.h Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 8/9] bfs: remove multiple assignments Dmitri Vorobiev
2008-01-24 22:32 ` [PATCH 9/9] bfs: use the proper header file for inclusion Dmitri Vorobiev
2008-01-25 10:25 ` [PATCH 0/9] bfs: assorted cleanups Dmitri Vorobiev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1201213928-18183-6-git-send-email-dmitri.vorobiev@gmail.com \
    --to=dmitri.vorobiev@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tigran@aivazian.fsnet.co.uk \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®