Re: Pull request: TASK_KILLABLE

[Trond Myklebust <Trond.Myklebust@netapp.com>]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]


On Fri, 2008-02-01 at 12:54 +1100, Linus Torvalds wrote:
> No need to make that one-liner function be a GPL-only export, it's not 
> like any of the other regular sigpending functions are we export are 
> GPL-only either (dequeue_signal() is, but that is because we *really* 
> don't want people using that, and it's really about internal signal 
> handling behavior).

No. It was more in the spirit of "let's not export a function that
others may implement trivially using established interfaces". However if
you don't care, then here's a replacement.

Cheers
  Trond

[-- Attachment #2: Type: message/rfc822, Size: 800 bytes --]

From: Trond Myklebust <Trond.Myklebust@netapp.com>
Subject: Ensure that we export __fatal_signal_pending()
Date: Thu, 31 Jan 2008 20:40:29 -0500
Message-ID: <1201831343.3087.12.camel@heimdal.trondhjem.org>

It may be used by the modules nfs.ko and sunrpc.ko

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
---

 kernel/signal.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/signal.c b/kernel/signal.c
index 8054dd4..4333b6d 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -998,6 +998,7 @@ int fastcall __fatal_signal_pending(struct task_struct *tsk)
 {
 	return sigismember(&tsk->pending.signal, SIGKILL);
 }
+EXPORT_SYMBOL(__fatal_signal_pending);
 
 /*
  * Must be called under rcu_read_lock() or with tasklist_lock read-held.