From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Konrad Rzeszutek <konrad@darnok.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Greg KH <greg@kroah.com>,
michaelc@cs.wisc.edu, dwm@enoyolf.org, darnok@68k.org,
pjones@redhat.com, konradr@redhat.com,
konradr@linux.vnet.ibm.com, randy.dunlap@oracle.com,
hpa@zytor.com, lenb@kernel.org, mike.anderson@us.ibm.com,
dwm@austin.ibm.com, arjan@infradead.org,
Andy Whitcroft <apw@shadowen.org>
Subject: Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)
Date: Fri, 08 Feb 2008 23:32:12 -0600 [thread overview]
Message-ID: <1202535132.3102.107.camel@localhost.localdomain> (raw)
In-Reply-To: <20080209031026.GA14878@andromeda.dapyr.net>
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote:
> + if (hdr->id == id_nic) {
> + pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >> 8,
> + (nic->pci_bdf & 0xff));
> + if (pci_dev) {
> + rc = sysfs_create_link(&ibft_kobj->kobj,
> + &pci_dev->dev.kobj, "device");
> + pci_dev_put(pci_dev);
> + }
pci_get_bus_and_slot fails in the presence of PCI domains, which are
getting to be fairly common even in medium sized servers ... what
happens in that case?
James
next prev parent reply other threads:[~2008-02-09 5:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 19:47 Konrad Rzeszutek
2008-02-09 3:10 ` REPOST: " Konrad Rzeszutek
2008-02-09 5:17 ` James Bottomley
2008-02-09 5:23 ` James Bottomley
2008-02-09 5:32 ` James Bottomley [this message]
2008-02-11 23:35 ` Konrad Rzeszutek
2008-02-12 0:45 ` Greg KH
2008-02-12 0:56 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202535132.3102.107.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=arjan@infradead.org \
--cc=darnok@68k.org \
--cc=dwm@austin.ibm.com \
--cc=dwm@enoyolf.org \
--cc=greg@kroah.com \
--cc=hpa@zytor.com \
--cc=konrad@darnok.org \
--cc=konradr@linux.vnet.ibm.com \
--cc=konradr@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=mike.anderson@us.ibm.com \
--cc=pjones@redhat.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome