From: <gregkh@suse.de>
To: harvey.harrison@gmail.com, akpm@linux-foundation.org,
greg@kroah.com, gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: patch debugfs-fix-sparse-warnings.patch added to gregkh-2.6 tree
Date: Tue, 19 Feb 2008 10:50:40 -0800 [thread overview]
Message-ID: <1203447040988@kroah.org> (raw)
In-Reply-To: <1202951296.18204.39.camel@brick>
This is a note to let you know that I've just added the patch titled
Subject: debugfs: fix sparse warnings
to my gregkh-2.6 tree. Its filename is
debugfs-fix-sparse-warnings.patch
This tree can be found at
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/
>From harvey.harrison@gmail.com Wed Feb 13 17:08:21 2008
From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Wed, 13 Feb 2008 17:08:16 -0800
Subject: debugfs: fix sparse warnings
To: Greg KH <greg@kroah.com>, Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Message-ID: <1202951296.18204.39.camel@brick>
extern does not belong in C files, move declaration to linux/debugfs.h
fs/debugfs/file.c:42:30: warning: symbol 'debugfs_file_operations' was not declared. Should it be static?
fs/debugfs/file.c:54:31: warning: symbol 'debugfs_link_operations' was not declared. Should it be static?
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
fs/debugfs/inode.c | 4 ----
include/linux/debugfs.h | 5 +++++
2 files changed, 5 insertions(+), 4 deletions(-)
--- a/fs/debugfs/inode.c
+++ b/fs/debugfs/inode.c
@@ -29,10 +29,6 @@
#define DEBUGFS_MAGIC 0x64626720
-/* declared over in file.c */
-extern struct file_operations debugfs_file_operations;
-extern struct inode_operations debugfs_link_operations;
-
static struct vfsmount *debugfs_mount;
static int debugfs_mount_count;
--- a/include/linux/debugfs.h
+++ b/include/linux/debugfs.h
@@ -27,6 +27,11 @@ struct debugfs_blob_wrapper {
};
#if defined(CONFIG_DEBUG_FS)
+
+/* declared over in file.c */
+extern const struct file_operations debugfs_file_operations;
+extern const struct inode_operations debugfs_link_operations;
+
struct dentry *debugfs_create_file(const char *name, mode_t mode,
struct dentry *parent, void *data,
const struct file_operations *fops);
Patches currently in gregkh-2.6 which might be from harvey.harrison@gmail.com are
driver/debugfs-fix-sparse-warnings.patch
prev parent reply other threads:[~2008-02-19 18:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-14 1:08 [PATCH] debugfs: fix sparse warnings Harvey Harrison
2008-02-19 18:50 ` gregkh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203447040988@kroah.org \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome