mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Balaji Rao <balajirrao@gmail.com>,
	Dave Jones <davej@codemonkey.org.uk>,
	Yi Yang <yi.y.yang@intel.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Frans Pop <elendil@planet.nl>, Yinghai Lu <yhlu.kernel@gmail.com>,
	Ingo Molnar <mingo@elte.hu>, Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 03/11] cpufreq: fix kobject reference count handling
Date: Thu, 21 Feb 2008 15:47:59 -0800	[thread overview]
Message-ID: <1203637687-7273-3-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <20080221234649.GB7128@kroah.com>

From: Balaji Rao <balajirrao@gmail.com>

The cpufreq core should not take an extra kobject reference count for no
reason, and then refuse to release it.  This has been reported as
keeping machines from properly powering down all the way.


Signed-off-by: Balaji Rao <balajirrao@gmail.com>
Cc: Dave Jones <davej@codemonkey.org.uk>
Cc: Yi Yang <yi.y.yang@intel.com>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Frans Pop <elendil@planet.nl>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/cpufreq/cpufreq.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 64926aa..89a29cd 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1006,14 +1006,6 @@ static int __cpufreq_remove_dev (struct sys_device * sys_dev)
 	}
 #endif
 
-
-	if (!kobject_get(&data->kobj)) {
-		spin_unlock_irqrestore(&cpufreq_driver_lock, flags);
-		cpufreq_debug_enable_ratelimit();
-		unlock_policy_rwsem_write(cpu);
-		return -EFAULT;
-	}
-
 #ifdef CONFIG_SMP
 
 #ifdef CONFIG_HOTPLUG_CPU
-- 
1.5.4


  parent reply	other threads:[~2008-02-21 23:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-21 23:46 [GIT PATCH] driver core fixes against 2.6.25-rc2 git Greg KH
2008-02-21 23:47 ` [PATCH 01/11] Fix broken utf-8 encodings in ja_JP translation of stable_kernel_rules.txt Greg Kroah-Hartman
2008-02-21 23:47 ` [PATCH 02/11] slabinfo: fall back from /sys/kernel/slab to /sys/slab Greg Kroah-Hartman
2008-02-21 23:47 ` Greg Kroah-Hartman [this message]
2008-02-21 23:53   ` [PATCH 03/11] cpufreq: fix kobject reference count handling Dave Jones
2008-02-21 23:48 ` [PATCH 04/11] driver-core: fix kernel-doc function parameters Greg Kroah-Hartman
2008-02-21 23:48 ` [PATCH 05/11] Driver core: Fix error handling in bus_add_driver() Greg Kroah-Hartman
2008-02-21 23:48 ` [PATCH 06/11] ide: mark "ide=reverse" option as obsolete Greg Kroah-Hartman
2008-02-21 23:48 ` [PATCH 07/11] stable_kernel_rules: fix must already be in mainline Greg Kroah-Hartman
2008-02-21 23:48 ` [PATCH 08/11] UIO: fix Greg's stupid changes Greg Kroah-Hartman
2008-02-21 23:48 ` [PATCH 09/11] PM: Remove unbalanced mutex_unlock() from dpm_resume() Greg Kroah-Hartman
2008-02-21 23:48 ` [PATCH 10/11] POWERPC: fix typo in pseries/power.c Greg Kroah-Hartman
2008-02-21 23:48 ` [PATCH 11/11] modules: do not try to add sysfs attributes if !CONFIG_SYSFS Greg Kroah-Hartman
2008-02-22  7:56 ` [GIT PATCH] driver core fixes against 2.6.25-rc2 git Sam Ravnborg
2008-02-22 19:56   ` Greg KH
2008-02-22 20:07     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1203637687-7273-3-git-send-email-gregkh@suse.de \
    --to=gregkh@suse.de \
    --cc=balajirrao@gmail.com \
    --cc=davej@codemonkey.org.uk \
    --cc=elendil@planet.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=stern@rowland.harvard.edu \
    --cc=yhlu.kernel@gmail.com \
    --cc=yi.y.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome