From: Ian Campbell <ijc@hellion.org.uk>
To: Adrian Bunk <bunk@kernel.org>
Cc: Jeremy Fitzhardinge <jeremy@xensource.com>,
chrisw@sous-sol.org, xen-devel@lists.xensource.com,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] make xen-blkfront.c:blkif_getgeo() static
Date: Fri, 22 Feb 2008 20:44:59 +0000 [thread overview]
Message-ID: <1203713099.28436.20.camel@cthulhu.hellion.org.uk> (raw)
In-Reply-To: <20080222195829.GH1409@cs181133002.pp.htv.fi>
On Fri, 2008-02-22 at 21:58 +0200, Adrian Bunk wrote:
> This patch makes the needlessly global blkif_getgeo() static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Acked-by: Ian Campbell <ijc@hellion.org.uk>
>
> ---
> 6f34bfdbb8c24e06d982ccaccd24c25dba5b1956 diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index 9c6f3f9..ae7ee16 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -136,7 +136,7 @@ static void blkif_restart_queue_callback(void *arg)
> schedule_work(&info->work);
> }
>
> -int blkif_getgeo(struct block_device *bd, struct hd_geometry *hg)
> +static int blkif_getgeo(struct block_device *bd, struct hd_geometry *hg)
> {
> /* We don't have real geometry info, but let's at least return
> values consistent with the size of the device */
>
>
--
Ian Campbell
WHERE CAN THE MATTER BE
Oh, dear, where can the matter be
When it's converted to energy?
There is a slight loss of parity.
Johnny's so long at the fair.
prev parent reply other threads:[~2008-02-22 20:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-22 19:58 Adrian Bunk
2008-02-22 20:44 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203713099.28436.20.camel@cthulhu.hellion.org.uk \
--to=ijc@hellion.org.uk \
--cc=bunk@kernel.org \
--cc=chrisw@sous-sol.org \
--cc=jeremy@xensource.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®