mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <haveblue@us.ibm.com>
To: srinivasa <srinivasa@in.ibm.com>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	ananth@in.ibm.com, Jim Keniston <jkenisto@us.ibm.com>,
	srikar@linux.vnet.ibm.com
Subject: Re: [RFC] [PATCH] To refuse users from probing preempt_schedule()
Date: Sun, 24 Feb 2008 22:20:24 -0800	[thread overview]
Message-ID: <1203920424.6662.14.camel@nimitz.home.sr71.net> (raw)
In-Reply-To: <200802251127.40579.srinivasa@in.ibm.com>

On Mon, 2008-02-25 at 11:27 +0530, srinivasa wrote:
> This patch prohibits user from probing preempt_schedule(). One way of
> prohibiting the user from probing functions is by marking such 
> functions with __kprobes. But this method doesn't work for those functions,
> which are already marked to different section like preempt_schedule()
> (belongs to __sched section). So we use blacklist approach to refuse user
> from probing these functions.

preempt_schedule() does sound really, really important.  But, what kinds
of functions can't be kprobed?  It would be nice to give that blacklist
a nice comment on the topic. :)

Also, have you strained your brains to think of other functions that
this should be applied to?  Is it just for functions that are sensitive
and already have an assigned section?  Might be nice to call that out
explicitly.

-- Dave


  reply	other threads:[~2008-02-25  6:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-25  5:57 srinivasa
2008-02-25  6:20 ` Dave Hansen [this message]
2008-02-25  6:55   ` Srinivasa DS
2008-03-04  8:25 ` Andrew Morton
2008-03-04  8:56   ` Srinivasa DS

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1203920424.6662.14.camel@nimitz.home.sr71.net \
    --to=haveblue@us.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=ananth@in.ibm.com \
    --cc=jkenisto@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srikar@linux.vnet.ibm.com \
    --cc=srinivasa@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®