From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: lenb@kernel.org
Cc: ibm-acpi-devel@lists.sourceforge.net, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Zdenek Kabelac <zdenek.kabelac@gmail.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Lukas Hejtmanek <xhejtman@ics.muni.cz>
Subject: ACPI: thinkpad-acpi: fix hotkey_get_tablet_mode
Date: Tue, 26 Feb 2008 19:12:35 -0300 [thread overview]
Message-ID: <1204063955-5739-1-git-send-email-hmh@hmh.eng.br> (raw)
In-Reply-To: <20080225200354.GE16513@khazad-dum.debian.net>
I used the wrong return convention on hotkey_get_tablet_mode(), breaking a
lot of stuff. Bad Henrique!
Fix it to return the status in the parameter-by-reference, and IO status on
the function return value. Duh.
Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Zdenek Kabelac <zdenek.kabelac@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Lukas Hejtmanek <xhejtman@ics.muni.cz>
---
drivers/misc/thinkpad_acpi.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c
index bb269d0..6cb7812 100644
--- a/drivers/misc/thinkpad_acpi.c
+++ b/drivers/misc/thinkpad_acpi.c
@@ -1078,7 +1078,8 @@ static int hotkey_get_tablet_mode(int *status)
if (!acpi_evalf(hkey_handle, &s, "MHKG", "d"))
return -EIO;
- return ((s & TP_HOTKEY_TABLET_MASK) != 0);
+ *status = ((s & TP_HOTKEY_TABLET_MASK) != 0);
+ return 0;
}
/*
--
1.5.4.2
prev parent reply other threads:[~2008-02-26 22:13 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 9:39 2.6.25-rc2 Regression Thinkpad acpi Lukas Hejtmanek
2008-02-25 11:47 ` Rafael J. Wysocki
2008-02-25 20:03 ` Henrique de Moraes Holschuh
2008-02-25 20:49 ` Lukas Hejtmanek
2008-02-25 21:01 ` Henrique de Moraes Holschuh
2008-02-25 22:07 ` Lukas Hejtmanek
2008-02-25 23:00 ` Henrique de Moraes Holschuh
2008-02-25 23:05 ` Rafael J. Wysocki
2008-02-27 11:54 ` Dell OptiPlex 320 - Core 2 Duo Nuno Tavares
2008-02-27 13:09 ` Xavier Bestel
2008-02-27 14:32 ` Lennart Sorensen
2008-02-26 18:49 ` 2.6.25-rc2 Regression Thinkpad acpi Lukas Hejtmanek
2008-03-04 19:45 ` Jens Axboe
2008-03-04 21:09 ` Alexey Starikovskiy
2008-03-04 21:12 ` Jens Axboe
2008-03-04 21:24 ` Alexey Starikovskiy
2008-03-12 12:59 ` Jens Axboe
2008-03-12 13:17 ` Henrique de Moraes Holschuh
2008-03-12 13:24 ` Jens Axboe
2008-03-12 13:35 ` Henrique de Moraes Holschuh
2008-03-12 13:55 ` Lukas Hejtmanek
2008-03-12 17:39 ` Henrique de Moraes Holschuh
2008-03-12 18:52 ` Arkadiusz Miskiewicz
2008-03-12 19:36 ` Lukas Hejtmanek
2008-03-12 21:13 ` Henrique de Moraes Holschuh
2008-03-13 7:30 ` Arkadiusz Miskiewicz
2008-03-13 7:33 ` Lukas Hejtmanek
2008-03-13 12:05 ` Jens Axboe
2008-03-13 12:23 ` Lukas Hejtmanek
2008-03-13 12:46 ` Jens Axboe
2008-03-13 12:55 ` Lukas Hejtmanek
2008-03-13 12:59 ` Jens Axboe
2008-03-13 13:09 ` Lukas Hejtmanek
2008-03-13 13:13 ` Jens Axboe
2008-03-13 14:37 ` Alexey Starikovskiy
2008-03-13 14:39 ` Jens Axboe
2008-03-13 14:52 ` Alexey Starikovskiy
2008-03-13 14:59 ` Jens Axboe
2008-03-13 15:04 ` Alexey Starikovskiy
2008-03-13 15:09 ` Jens Axboe
2008-03-13 22:55 ` Henrique de Moraes Holschuh
2008-03-13 22:53 ` Henrique de Moraes Holschuh
2008-03-13 23:17 ` Henrique de Moraes Holschuh
2008-03-14 7:05 ` Jens Axboe
2008-03-14 7:30 ` Jens Axboe
2008-03-14 18:23 ` Arkadiusz Miskiewicz
2008-02-25 23:03 ` Tomas Carnecky
2008-02-26 22:12 ` Henrique de Moraes Holschuh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204063955-5739-1-git-send-email-hmh@hmh.eng.br \
--to=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=xhejtman@ics.muni.cz \
--cc=zdenek.kabelac@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®