From: Matthew Wilcox <matthew@wil.cx>
To: linux-kernel@vger.kernel.org
Cc: Matthew Wilcox <matthew@wil.cx>, Matthew Wilcox <willy@linux.intel.com>
Subject: [PATCH 02/12] Add semaphore.h to kernel_lock.c
Date: Thu, 28 Feb 2008 01:33:51 -0500 [thread overview]
Message-ID: <1204180441-8540-2-git-send-email-matthew@wil.cx> (raw)
In-Reply-To: <1204180441-8540-1-git-send-email-matthew@wil.cx>
kernel_lock.c uses DECLARE_MUTEX, up() and down() without explicitly
including asm/semaphore.h. This is fragile and leaves it vulnerable
to breakage during header reorganisations.
Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
---
lib/kernel_lock.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/lib/kernel_lock.c b/lib/kernel_lock.c
index 812dbf0..fbc11a3 100644
--- a/lib/kernel_lock.c
+++ b/lib/kernel_lock.c
@@ -8,6 +8,7 @@
#include <linux/smp_lock.h>
#include <linux/module.h>
#include <linux/kallsyms.h>
+#include <asm/semaphore.h>
/*
* The 'big kernel semaphore'
--
1.5.4.1
next prev parent reply other threads:[~2008-02-28 6:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 0:36 [PATCHES] semaphore rewrite Matthew Wilcox
2008-02-28 6:33 ` [PATCH 01/12] Fix quota.h includes Matthew Wilcox
2008-02-28 6:33 ` Matthew Wilcox [this message]
2008-02-28 6:33 ` [PATCH 03/12] arch: Remove unnecessary inclusions of asm/semaphore.h Matthew Wilcox
2008-02-28 6:33 ` [PATCH 04/12] net: " Matthew Wilcox
2008-02-28 6:33 ` [PATCH 05/12] drivers: " Matthew Wilcox
2008-02-28 6:33 ` [PATCH 06/12] fs: " Matthew Wilcox
2008-02-28 6:33 ` [PATCH 07/12] include: " Matthew Wilcox
2008-02-28 6:33 ` [PATCH 08/12] kernel: " Matthew Wilcox
2008-02-28 6:33 ` [PATCH 09/12] lib: " Matthew Wilcox
2008-02-28 6:33 ` [PATCH 10/12] security: " Matthew Wilcox
2008-02-28 6:34 ` [PATCH 11/12] Generic semaphore implementation Matthew Wilcox
2008-02-28 6:34 ` [PATCH 12/12] Convert asm/semaphore.h users to linux/semaphore.h Matthew Wilcox
2008-02-28 7:18 ` [PATCH 11/12] Generic semaphore implementation Ingo Molnar
2008-02-29 0:39 ` Matthew Wilcox
2008-02-29 0:50 ` Harvey Harrison
2008-02-29 1:43 ` Andrew Morton
2008-02-29 5:30 ` Matthew Wilcox
2008-02-29 17:42 ` Haavard Skinnemoen
2008-02-29 19:21 ` Ingo Molnar
2008-02-29 2:00 ` Stephen Rothwell
2008-02-29 2:10 ` Andrew Morton
2008-02-29 5:32 ` Matthew Wilcox
2008-02-29 6:43 ` Stephen Rothwell
2008-02-29 16:14 ` Linus Torvalds
2008-02-29 1:57 ` Andrew Morton
2008-02-29 5:43 ` Matthew Wilcox
2008-02-29 2:37 ` Harvey Harrison
2008-02-29 2:47 ` [PATCH] semaphore: remove likely/unlikely annotations Harvey Harrison
2008-03-03 14:54 ` [PATCH 11/12] Generic semaphore implementation Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204180441-8540-2-git-send-email-matthew@wil.cx \
--to=matthew@wil.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®