From: Laurent Vivier <Laurent.Vivier@bull.net>
To: Andreas Schwab <schwab@suse.de>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][v2] Modify loop device to be able to manage partitions of the disk image
Date: Fri, 07 Mar 2008 13:45:09 +0100 [thread overview]
Message-ID: <1204893909.4315.32.camel@frecb07144> (raw)
In-Reply-To: <jepru6n283.fsf@sykes.suse.de>
Le vendredi 07 mars 2008 à 13:33 +0100, Andreas Schwab a écrit :
> Laurent Vivier <Laurent.Vivier@bull.net> writes:
>
> > +static int __init max_part_setup(char *str)
> > +{
> > + loop_max_part = simple_strtol(str, NULL, 0);
> > + if (loop_max_part > (1UL << (MINORBITS - 1))) {
> > + /* we must keep at least one bit for loop device number */
> > + printk(KERN_ERR
> > + "loop: loop_max_part cannot be greater than %d\n",
> > + 1UL << (MINORBITS - 1));
>
> Since the argument is of type unsigned long you should use %ld or %lu.
Yes, I wait for some more comments and I will re-send a [v3].
Laurent
--
----------------- Laurent.Vivier@bull.net ------------------
"Programmers who subconsciously view themselves as artists
will enjoy what they do and will do it better." D. Knuth
next prev parent reply other threads:[~2008-03-07 12:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-07 12:27 Laurent Vivier
2008-03-07 12:33 ` Andreas Schwab
2008-03-07 12:45 ` Laurent Vivier [this message]
2008-03-07 16:34 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204893909.4315.32.camel@frecb07144 \
--to=laurent.vivier@bull.net \
--cc=linux-kernel@vger.kernel.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®