From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756176AbYCGXof (ORCPT ); Fri, 7 Mar 2008 18:44:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754179AbYCGXoN (ORCPT ); Fri, 7 Mar 2008 18:44:13 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:40417 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759611AbYCGXoL (ORCPT ); Fri, 7 Mar 2008 18:44:11 -0500 Subject: Re: headersinstall of kvm.h does not work From: David Woodhouse To: Christian Borntraeger Cc: Avi Kivity , Sam Ravnborg , kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org In-Reply-To: <200803071326.06682.borntraeger@de.ibm.com> References: <200803071326.06682.borntraeger@de.ibm.com> Content-Type: text/plain Date: Sat, 08 Mar 2008 00:43:38 +0100 Message-Id: <1204933418.2495.14.camel@shinybook.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-1.fc8.dwmw2.1) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2008-03-07 at 13:26 +0100, Christian Borntraeger wrote: > +unifdef-$(CONFIG_HAVE_KVM) += kvm.h > unifdef-y += llc.h > unifdef-y += loop.h > ----snip------ > > This patch does not work. Kbuild (scripts/Makefile.headersinst) does > not check the config file, so kvm.h is never installed. > > Sam is there an easy way to allow constructs like > "unifdef-$(CONFIG_FOO)"? That might be justifiable for HAVE_xxx which is a constant for any given architecture -- but I predict that soon as we add such a facility, it would get abused for stuff which really _is_ configurable. And that would make me sad. -- dwmw2