From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755561AbYCLWNT (ORCPT ); Wed, 12 Mar 2008 18:13:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755187AbYCLWNA (ORCPT ); Wed, 12 Mar 2008 18:13:00 -0400 Received: from mtagate6.uk.ibm.com ([195.212.29.139]:15102 "EHLO mtagate6.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754222AbYCLWM7 (ORCPT ); Wed, 12 Mar 2008 18:12:59 -0400 Subject: Re: [patch 10/10] System z large page support. From: Gerald Schaefer Reply-To: gerald.schaefer@de.ibm.com To: Dave Hansen Cc: Martin Schwidefsky , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org In-Reply-To: <1205344332.9828.92.camel@nimitz.home.sr71.net> References: <20080312173155.703966894@de.ibm.com> <20080312173218.404592017@de.ibm.com> <1205344332.9828.92.camel@nimitz.home.sr71.net> Content-Type: text/plain Date: Wed, 12 Mar 2008 23:14:31 +0100 Message-Id: <1205360071.5237.10.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.8.0 (2.8.0-40.el5) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2008-03-12 at 10:52 -0700, Dave Hansen wrote: > > > > +pte_t *huge_pte_alloc(struct mm_struct *mm, unsigned long addr) > > +{ > > + pgd_t *pgdp; > > + pud_t *pudp; > > + pmd_t *pmdp = NULL; > > + > > + pgdp = pgd_offset(mm, addr); > > + pudp = pud_alloc(mm, pgdp, addr); > > + if (pudp) > > + pmdp = pmd_alloc(mm, pudp, addr); > > + return (pte_t *) pmdp; > > +} > > That looks pretty generic. Why can't you share with the version we > already have? What version do you mean? Every architecture with hugetlbfs support has its own huge_pte_alloc() function in arch//mm/hugetlbfs.c, and they are all doing slightly different things. -- Gerald Schaefer