Re: + revert-acpi-thermal-fixup.patch added to -mm tree

["Zhang, Rui" <rui.zhang@intel.com>]

Hi, Andrea,

could you please attach the acpidump of your SVM please?
And it would be really great if you can get the sys log when the system
hangs.

thanks,
rui

On Wed, 2008-03-12 at 10:02 +0800, Zhang, Rui wrote:
> On Wed, 2008-03-12 at 01:50 +0800, akpm@linux-foundation.org wrote:
> > 
> > The patch titled
> >      revert "ACPI: thermal fixup"
> > has been added to the -mm tree.  Its filename is
> >      revert-acpi-thermal-fixup.patch
> > 
> > Before you just go and hit "reply", please:
> >    a) Consider who else should be cc'ed
> >    b) Prefer to cc a suitable mailing list as well
> >    c) Ideally: find the original patch on the mailing list and do a
> >       reply-to-all to that, adding suitable additional cc's
> > 
> > *** Remember to use Documentation/SubmitChecklist when testing your
> > code ***
> > 
> > See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to
> > find
> > out what to do about this
> > 
> > The current -mm tree may be found at
> > http://userweb.kernel.org/~akpm/mmotm/
> > 
> > ------------------------------------------------------
> > Subject: revert "ACPI: thermal fixup"
> > From: Andrew Morton <akpm@linux-foundation.org>
> > 
> > Revert
> > 
> > commit 653a00c9662304ef72a3eb4e681c91720960e0b4
> > Author: Zhang Rui <rui.zhang@intel.com>
> > Date:   Thu Jan 17 15:51:18 2008 +0800
> > 
> > Andrea reports
> > 
> >   this changeset prevents my SVM test system from booting with
> >   CONFIG_ACPI_THERMAL=y, so I set CONFIG_ACPI_THERMAL=n for now.
> 
> Andrea,
> can you attach the acpidump output ?
> 
> thanks,
> rui
> > Cc: Zhang Rui <rui.zhang@intel.com>
> > Cc: Thomas Sujith <sujith.thomas@intel.com>
> > Cc: Len Brown <len.brown@intel.com>
> > Cc: Andrea Arcangeli <andrea@qumranet.com>
> > Cc: Nick Piggin <npiggin@suse.de>
> > Cc: Christoph Lameter <clameter@sgi.com>
> > Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > ---
> > 
> >  drivers/acpi/thermal.c |   42 ++++++++++++++++-----------------------
> >  1 file changed, 18 insertions(+), 24 deletions(-)
> > 
> > diff -puN drivers/acpi/thermal.c~revert-acpi-thermal-fixup
> > drivers/acpi/thermal.c
> > --- a/drivers/acpi/thermal.c~revert-acpi-thermal-fixup
> > +++ a/drivers/acpi/thermal.c
> > @@ -1018,9 +1018,7 @@ static int acpi_thermal_cooling_device_c
> >  {
> >         struct acpi_device *device = cdev->devdata;
> >         struct acpi_thermal *tz = thermal->devdata;
> > -       struct acpi_device *dev;
> > -       acpi_status status;
> > -       acpi_handle handle;
> > +       acpi_handle handle = device->handle;
> >         int i;
> >         int j;
> >         int trip = -1;
> > @@ -1036,13 +1034,12 @@ static int acpi_thermal_cooling_device_c
> >                 trip++;
> >                 for (i = 0; i < tz->trips.passive.devices.count;
> >                     i++) {
> > -                       handle = tz->trips.passive.devices.handles[i];
> > -                       status = acpi_bus_get_device(handle, &dev);
> > -                       if (ACPI_SUCCESS(status) && (dev == device)) {
> > -                               result = action(thermal, trip, cdev);
> > -                               if (result)
> > -                                       goto failed;
> > -                       }
> > +                       if (tz->trips.passive.devices.handles[i] !=
> > +                               handle)
> > +                               continue;
> > +                       result = action(thermal, trip, cdev);
> > +                       if (result)
> > +                               goto failed;
> >                 }
> >         }
> > 
> > @@ -1053,24 +1050,21 @@ static int acpi_thermal_cooling_device_c
> >                 for (j = 0;
> >                     j < tz->trips.active[i].devices.count;
> >                     j++) {
> > -                       handle =
> > tz->trips.active[i].devices.handles[j];
> > -                       status = acpi_bus_get_device(handle, &dev);
> > -                       if (ACPI_SUCCESS(status) && (dev == device)) {
> > -                               result = action(thermal, trip, cdev);
> > -                               if (result)
> > -                                       goto failed;
> > -                       }
> > +                       if (tz->trips.active[i].devices.
> > +                                               handles[j] != handle)
> > +                               continue;
> > +                       result = action(thermal, trip, cdev);
> > +                       if (result)
> > +                               goto failed;
> >                 }
> >         }
> > 
> >         for (i = 0; i < tz->devices.count; i++) {
> > -               handle = tz->devices.handles[i];
> > -               status = acpi_bus_get_device(handle, &dev);
> > -               if (ACPI_SUCCESS(status) && (dev == device)) {
> > -                       result = action(thermal, -1, cdev);
> > -                       if (result)
> > -                               goto failed;
> > -               }
> > +               if (tz->devices.handles[i] != handle)
> > +                       continue;
> > +               result = action(thermal, -1, cdev);
> > +               if (result)
> > +                       goto failed;
> >         }
> > 
> >  failed:
> > _
> > 
> > Patches currently in -mm which might be from akpm@linux-foundation.org
> > are
> > 
> > origin.patch
> > poweroff-workaround.patch
> > git-x86.patch
> > arch-x86-kernel-ptracec-fix-defined-but-unused-warnings.patch
> > git-kgdb-light.patch
> > git-acpi-fixup.patch
> > acpi-enable-c3-power-state-on-dell-inspiron-8200.patch
> > git-alsa.patch
> > git-alsa-fix-git-conflicts.patch
> > git-arm-master.patch
> > cifs-hack-around-biuld-error.patch
> > git-powerpc-fix-git-rejects.patch
> > revert-gregkh-driver-video-add-the-go7007-driver.patch
> > fix-gregkh-driver-net-convert-the-phy_device-file-to-use-bus_find_device_by_name.patch
> > driver-core-debug-for-bad-dev_attr_show-return-value.patch
> > git-drm.patch
> > git-dvb.patch
> > drivers-media-video-pvrusb2-pvrusb2-sysfsc-fix-printk-warnings.patch
> > git-hwmon.patch
> > git-hrt.patch
> > git-ieee1394.patch
> > drivers-input-touchscreen-ads7846c-fix-uninitialized-var-warning.patch
> > maple-add-driver-for-sega-dreamcast-controller.patch
> > git-kvm.patch
> > git-leds.patch
> > git-net.patch
> > git-net-fix-build-with-config_net=n.patch
> > update-smc91x-driver-with-arm-versatile-board-info.patch
> > git-nfsd.patch
> > git-ocfs2.patch
> > drivers-pcmcia-soc_commonc-convert-soc_pcmcia_sockets_lock-into-a-mutex-and-make-it-static.patch
> > git-selinux.patch
> > git-sh.patch
> > scsi-aic94xx-cleanups.patch
> > scsi-chc-fix-shadowed-variable-warnings-checkpatch-fixes.patch
> > git-block-git-rejects.patch
> > git-unionfs.patch
> > git-v9fs.patch
> > git-watchdog.patch
> > git-semaphore-git-rejects.patch
> > revert-acpi-thermal-fixup.patch
> > remove-sparse-warning-for-mmzoneh-checkpatch-fixes.patch
> > fix-invalidate_inode_pages2_range-to-not-clear-ret-checkpatch-fixes.patch
> > vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch
> > vm-dont-run-touch_buffer-during-buffercache-lookups.patch
> > capabilities-implement-per-process-securebits-warning-fix.patch
> > lsm-introduce-inode_getsecid-and-ipc_getsecid-hooks-checkpatch-fixes.patch
> > lsm-audit-introduce-generic-audit-lsm-hooks-checkpatch-fixes.patch
> > selinux-use-new-audit-hooks-remove-redundant-exports-checkpatch-fixes.patch
> > audit-final-renamings-and-cleanup-checkpatch-fixes.patch
> > make-dev-kmem-a-config-option-fix.patch
> > misc-phantom-add-compat-ioctl-checkpatch-fixes.patch
> > kernel-add-clamp-and-clamp_t-macros-checkpatch-fixes.patch
> > kernel-add-clamp-and-clamp_t-macros-fix.patch
> > sysrq-add-show-backtrace-on-all-cpus-function-checkpatch-fixes.patch
> > sysrq-add-show-backtrace-on-all-cpus-function-checkpatch-fixes-cleanup.patch
> > r-o-bind-mounts-elevate-write-count-for-callers-of-vfs_mkdir-fix.patch
> > r-o-bind-mounts-elevate-write-count-for-xattr_permission-callers-fix.patch
> > r-o-bind-mounts-get-write-access-for-vfs_rename-callers-fix.patch
> > r-o-bind-mounts-check-mnt-instead-of-superblock-directly-fix.patch
> > r-o-bind-mounts-check-mnt-instead-of-superblock-directly-fix-2.patch
> > r-o-bind-mounts-get-callers-of-vfs_mknod-create-fix.patch
> > fs-inodec-use-hlist_for_each_entry-checkpatch-fixes.patch
> > add-rcu_assign_index-if-ever-needed-fix.patch
> > uart_get_baud_rate-stop-mangling-termios-fix.patch
> > oprofile-change-cpu_buffer-from-array-to-per_cpu-variable-checkpatch-fixes.patch
> > vt-notifier-extension-for-accessibility-checkpatch-fixes.patch
> > kprobes-prevent-probing-of-preempt_schedule-fix.patch
> > kprobes-prevent-probing-of-preempt_schedule-checkpatch-fixes.patch
> > rtc-isl1208-new-style-conversion-and-minor-bug-fixes-checkpatch-fixes.patch
> > rtc-pcf8563-new-style-conversion-checkpatch-fixes.patch
> > rtc-pcf8563-new-style-conversion-checkpatch-fixes-fix.patch
> > rtc-x1205-new-style-conversion-checkpatch-fixes.patch
> > fb-add-support-for-foreign-endianness-force-it-on.patch
> > fbcon-replace-mono_col-macro-with-static-inline-fix.patch
> > fat_valid_media-remove-pointless-test.patch
> > cgroup-api-files-update-cpusets-to-use-cgroup-structured-file-api-fix.patch
> > workqueues-shrink-cpu_populated_map-when-cpu-dies-fix.patch
> > ext4-is-broken.patch
> > ipc-use-ipc_buildid-directly-from-ipc_addid-cleanup.patch
> > ipmi-run-to-completion-fixes-checkpatch-fixes.patch
> > ipmi-style-fixes-in-the-system-interface-code-checkpatch-fixes.patch
> > elf-fix-shadowed-variables-in-fs-binfmt_elfc.patch
> > sgi-altix-mmtimer-allow-larger-number-of-timers-per-node-fix.patch
> > sgi-altix-mmtimer-allow-larger-number-of-timers-per-node-fix-2.patch
> > epcac-static-functions-and-integer-as-null-pointer-fixes-checkpatch-fixes.patch
> > keys-add-keyctl-function-to-get-a-security-label-fix.patch
> > procfs-task-exe-symlink-fix.patch
> > edd-add-default-mode-config_edd_off=n-override-with-edd=onoff-fix.patch
> > mm-bdi-export-bdi-attributes-in-sysfs-ia64-fix.patch
> > basic-braille-screen-reader-support-ppc-fix.patch
> > reiser4.patch
> > jens-broke-reiser4patch-added-to-mm-tree.patch
> > page-owner-tracking-leak-detector.patch
> > nr_blockdev_pages-in_interrupt-warning.patch
> > slab-leaks3-default-y.patch
> > profile-likely-unlikely-macros.patch
> > profile-likely-unlikely-macros-fix.patch
> > put_bh-debug.patch
> > shrink_slab-handle-bad-shrinkers.patch
> > getblk-handle-2tb-devices.patch
> > getblk-handle-2tb-devices-fix.patch
> > undeprecate-pci_find_device.patch
> > w1-build-fix.patch
> > 
> > 
> >