mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Walker <dwalker@mvista.com>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: lkml <linux-kernel@vger.kernel.org>, Hua Zhong <hzhong@gmail.com>,
	akpm@linux-foundation.org
Subject: Re: [PATCH v1] change likeliness accounting
Date: Fri, 14 Mar 2008 12:53:31 -0700	[thread overview]
Message-ID: <1205524411.10894.108.camel@localhost.localdomain> (raw)
In-Reply-To: <47D9B35C.9@tiscali.nl>


On Fri, 2008-03-14 at 00:06 +0100, Roel Kluin wrote:

> -	seq_printf(out, "|%9u|%9u\t%s()@:%s@%d\n", true, false,
> -			entry->func, entry->file, entry->line);
> +	sprint_symbol(function, entry->caller);
> +	seq_printf(out, "|%9u|%9u\t%s()@:%u\n", pos, neg, function,
> +					entry->label >> LP_LINE_SHIFT);

Looks like we're missing a "|" after the second %9u above .. You could
add that as long as your modifying this area.. Also your tabbing is a
little too heavy ..

I wonder if you think the change to saving the caller EIP is better than
saving the file name? The size saving in the likeliness struct is nice,
but since this is for debugging is not at all required ..

Overall it looks like a nice update/cleanup ..

(CC'd Andrew and Hua..)

Daniel


  reply	other threads:[~2008-03-14 19:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-13 23:06 Roel Kluin
2008-03-14 19:53 ` Daniel Walker [this message]
2008-03-14 20:26 ` Daniel Walker
2008-03-17  2:45 ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1205524411.10894.108.camel@localhost.localdomain \
    --to=dwalker@mvista.com \
    --cc=12o3l@tiscali.nl \
    --cc=akpm@linux-foundation.org \
    --cc=hzhong@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®