mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nikanth Karthikesan <knikanth@suse.de>
To: Jens Axboe <jens.axboe@oracle.com>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	Borislav Petkov <petkovbb@googlemail.com>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: ide_cd modifies hard_* members of request
Date: Tue, 18 Mar 2008 14:24:46 +0530	[thread overview]
Message-ID: <1205830486.7126.16.camel@nikanth-laptop.blr.novell.com> (raw)

Hi

Despite the warning in blkdev.h, that members of struct request starting
with hard_* are block layer internals, and no driver should touch them,
the ide_cd driver seems to fiddle around with it.

Is this reqd, or can this be made to work without the need for this?

If this reqd, why not provide a helper function for that in block layer
itself, may be, with a warning about usage?

Thanks
Nikanth Karthikesan



             reply	other threads:[~2008-03-18  9:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-18  8:54 Nikanth Karthikesan [this message]
2008-03-18 11:05 ` Boris Petkov
2008-03-18 11:08   ` Jens Axboe
2008-03-18 11:22     ` Boris Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1205830486.7126.16.camel@nikanth-laptop.blr.novell.com \
    --to=knikanth@suse.de \
    --cc=bzolnier@gmail.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petkovbb@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®