From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751223AbdH0Hgy (ORCPT ); Sun, 27 Aug 2017 03:36:54 -0400 Received: from forward4p.cmail.yandex.net ([77.88.31.19]:55366 "EHLO forward4p.cmail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750792AbdH0Hgx (ORCPT ); Sun, 27 Aug 2017 03:36:53 -0400 Authentication-Results: mxback5o.mail.yandex.net; dkim=pass header.i=@yandex.ru From: Evgeniy Polyakov Envelope-From: drustafa@yandex.ru To: Chen Lin , "linux-kernel@vger.kernel.org" Cc: "jiang.biao2@zte.com.cn" In-Reply-To: <1500451680-17885-1-git-send-email-chen.lin5@zte.com.cn> References: <1500451680-17885-1-git-send-email-chen.lin5@zte.com.cn> Subject: Re: [PATCH v2] w1:fix byteorder of W1_READ_ROM id under big-endian cpu MIME-Version: 1.0 Message-Id: <1206341503819410@web4g.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Sun, 27 Aug 2017 10:36:50 +0300 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chen 19.07.2017, 10:58, "Chen Lin" : > The byteorder of para rn(W1_READ_ROM id) pass to w1_slave_found must > be the same with the byterorder defined in struct w1_reg_num. > > The rn read from 'rv = w1_read_block(dev, (u8 *)&rn, 8)' is a byte > serial and not cpu endian relative, it need to change to cpu endian > before passed to w1_slave_found. But w1_reg_num has a different layout for be/le systems, isn't it enough? > Signed-off-by: Chen Lin > Reviewed-by: Jiang Biao > --- > Forgot the description in v1. > > --- >  drivers/w1/w1.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c > index 95ea7e6..c531545 100644 > --- a/drivers/w1/w1.c > +++ b/drivers/w1/w1.c > @@ -979,7 +979,7 @@ void w1_search(struct w1_master *dev, u8 search_type, w1_slave_found_callback cb >                          mutex_unlock(&dev->bus_mutex); > >                          if (rv == 8 && rn) > - cb(dev, rn); > + cb(dev, le64_to_cpu(rn)); > >                          break; >                  } > -- > 1.8.3.1