From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04A2326D4F9 for ; Thu, 19 Feb 2026 14:46:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771512401; cv=none; b=T2DeW7I3eNbnwHxRehpKP2uig/HfGw9BPO1t6VlO81WNNRo/6J4jol28L5hFcZ/1VZnIjqk2QwP9v5ZWCSyIW5yWryDiiyVvWjWC5vzY5iBF/q50XFHf4VvWCKTVi9c27myCnHHzB7ejRgTCWvHlbPhkhxfyrUfehxh49CYJD/E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771512401; c=relaxed/simple; bh=vNW766IFB2+DzF8pp6Pv6LonUz6vSFc3tsbmLtLXQ6k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nC/YHhfTzRfY7bBPURbvC5TQlBh+J8C6sGIKQKHss8LnAzIaVLST09d6IeECa65+Hxh7SytikKelYc5ZBmkBN90Rzfevzzy0wysd+PfIbvbSgJd/Ncl1Ri6DSHK5sbwG+2gE1azNrMD4KzuecwmW1at73GR4rIEq9WoL2E/Mhzw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=N3btbEW+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=X+zjEEkd; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="N3btbEW+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="X+zjEEkd" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61J56kxC3319692 for ; Thu, 19 Feb 2026 14:46:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yvBjsS8dM/m2taoBUTBY+/d+yJGb/O9XoBnXPJK6BXI=; b=N3btbEW+NNZnFii+ 1uWI90VEzMgkCX4UAN75fDIpRegoZ94H4jHGDd2E1qLacqacrMPRYC26PrrRm9t/ rcyiiYIYNceNi6DkYHu9rsOcwGuMzIoGsJpyD9o1PpckYyZlrxAs7YG7nPmNMXUe eIpG/hi/U26AssqNL2Nf4y+FOvApf1sw+cpPz78nIlDeCCoCdsH3RnsNX2e7/CqY m6fO83abjUrtU7wmx/Srcv48pAlN+Zo88NO+oIrQd0VxoIst7mxqRa3cTXEb+SNb DgWFqm2QRRn4BB6lz5xxaT08gs0+3mTjF2LZ4OBThNqKa0hwzJPfmW9nM0YEj98M b8Fxyw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cdv389fs8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Feb 2026 14:46:32 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-35464d7c539so1013826a91.0 for ; Thu, 19 Feb 2026 06:46:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771512392; x=1772117192; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yvBjsS8dM/m2taoBUTBY+/d+yJGb/O9XoBnXPJK6BXI=; b=X+zjEEkdNvcxc/xbH5qcVJ7iQIAp+twEnN09yIJs8lXtULJfRgztbWX06VLLESTITc z3B3I5PCDSbyXuzhyNxqoGA45+9hPeMbYq9nHJZVTELKfHj1D2Yb0uuRc7v1yBFqEiSP IOMilo5Z5BNYeqLl1scHM9R9jabUXt+n1ExnBs5lKluSrYE3MXUMXZA7Zp6ka9b4P65/ 0FB3kEkMcXs6P31Vl+G9Uw0raGF293PBGJ3Lja/InvCvFmPV65hjeLKF1IB40HdpOLLo fkMzhb5iZ7jwY5tHWglrxwzEbVB5N58CHFSY1xSqZA1lG8NsVDBD4WIxm0xtIaSK9Hfs asWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771512392; x=1772117192; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yvBjsS8dM/m2taoBUTBY+/d+yJGb/O9XoBnXPJK6BXI=; b=iNH7lAgOqWL9apjBb1d3oPIDYPO1QR5kOfK90+X1LlTeqpv546UCqlRvRusoLTzVeY mv+fKR9OLaqhra3RjxETHanE4994qrlBQW4fQEmhTkCi4MbnV7fp14uws4S3TxV55iMk qWJnKZlecsNkTJrqLQXiqBs+BDjXhh8y5yVrku58HvB1hxSQlB2S42KyUm/3Bkff0sST mgtYGo5KRkm40MtXiSCS5cyHQqrFYowKxZ9slHNlkntBhPd5CaJi8Xg+PagEruMkP1Uo nJonRN7AwHb0oPm5VDqf7YbLS0HN1FVvUYtQhJvh5WtEdLQw9lYIbxybPlKdwZxcrn4X eIig== X-Forwarded-Encrypted: i=1; AJvYcCWyfCPbzItjuBV7VBZdhPYDODA2ceV80tv5CicdYOYrn/yO87dTUZe8rLu/X/zNUQvO+WmIn7vxCrliT6k=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+2duWRHJ0u/c+TRDeGAs9QCOaxnirufb5YJPc/mRLkIkKwLOo 1pGEFUTjoXAtuvpiNjsqcFBXWAAej/xbC33nN0T7D5fRig/lS3Sc14HGHwHp159gv5lbKf78dPI xCnNXibVR4eoRmqBjJnOu8lejVI3OkRFNkYBtt8RjWO9jWQrCK8+DUbIYtZj94L6jrp4= X-Gm-Gg: AZuq6aKexYHTG/zjy6VcKQ6yhUQAUpoSbCycO1O6TIBPNXi8C4V4xCVGbLMMRq08O9b Ysfqvu6bQ4aSE3qG1rz+Et1cbrZjWYHOc2veajqBjomP2KX7IYTtxTEHVZBv1fUwtLfyY0HFKrl trB970zRrspry7c3oIMb57QaeXqDsnmZW9wy9QfFOXp1XFNnbs9mdAO9zoXp7Ujxz5ev14+p9N8 guFGxvdZ2VBMZUNXHeeKzze4nlQn7D+ls9J5mTeRzdmBnYnvyC5Wca1ovH5ny3abNzcBOicwm59 Js1hiriZls7Crk06+zqdugY94bhImiflEG+8NWjChP6tfH3a/dQCUSQI5+ex+jjTPXrX9PjCs51 X4Ro57WzwnjiZyLSJaaMzlSvHorV0I5A5cCYIoQF2WcSlWVSEygM8nQ== X-Received: by 2002:a17:90b:530c:b0:340:25f0:a9b with SMTP id 98e67ed59e1d1-358450eca59mr17324781a91.33.1771512391847; Thu, 19 Feb 2026 06:46:31 -0800 (PST) X-Received: by 2002:a17:90b:530c:b0:340:25f0:a9b with SMTP id 98e67ed59e1d1-358450eca59mr17324750a91.33.1771512391299; Thu, 19 Feb 2026 06:46:31 -0800 (PST) Received: from [192.168.1.6] ([49.204.108.219]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35894b32cbesm1520691a91.0.2026.02.19.06.46.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Feb 2026 06:46:30 -0800 (PST) Message-ID: <12063990-70fe-4faf-89fa-c74c7bd97f42@oss.qualcomm.com> Date: Thu, 19 Feb 2026 20:16:21 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 13/13] i2c: qcom-geni: Enable I2C on SA8255p Qualcomm platforms To: Konrad Dybcio , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com, chiluka.harish@oss.qualcomm.com References: <20260206174112.4149893-1-praveen.talari@oss.qualcomm.com> <20260206174112.4149893-14-praveen.talari@oss.qualcomm.com> <389dc762-bd20-44e5-a3fc-256b42f3c82a@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: <389dc762-bd20-44e5-a3fc-256b42f3c82a@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=ceffb3DM c=1 sm=1 tr=0 ts=69972248 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=SEi2w9hYDuVaAARFuk79KQ==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=0Va3wKG2juJEggPPLkUA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: LaleY8g2lm3DsR35-UJDy6LebA49Bk2p X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE5MDEzNSBTYWx0ZWRfX8QeRJbr7kwYs jOmO46qmjqyv/DVbt4GV4N2JwrGVgSuxBli/l+fweauMgXB4Mi5tmNa3EL19r7IGMWaGJvsRgj6 WAClIdF5bp+eiiLI0zYNhN/HAVIwnfvzdZ0p1D0+gqoKTyyf++aKJLtNQCHtNrRX1PElbTusmFW FgbvB71+zmZJyKJb5lRLg55DMHrDKpx/81mi7sXrP7hNcd8DPOhnkj4rqIlt4dKke0ASLBo0JM1 Rr2q6lH0u7FfP66SbTqHSPhqKl0ZDmcb9GW5bulSIdLMiGpAo4mwiFDCvY21lFx0BasriTEfRnG YOVq5fGwoLzHIQUk0H6I1u4wznbzBG0FAsyRUkMD/zB9M/W2Osa7+tXML84ifRZ2raq0yT1jIsC VFEL6hiC8goPvliaJn5G/pJ+4dhWFH72OHNZa767M+cTrEf7YWNJaRcXcYywMiFIQikEk+GkRB4 7j6lyY+1fTEbbiY6WJw== X-Proofpoint-ORIG-GUID: LaleY8g2lm3DsR35-UJDy6LebA49Bk2p X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-19_04,2026-02-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 bulkscore=0 clxscore=1015 malwarescore=0 impostorscore=0 suspectscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602190135 Hi On 2/17/2026 5:20 PM, Konrad Dybcio wrote: > On 2/6/26 6:41 PM, Praveen Talari wrote: >> The Qualcomm automotive SA8255p SoC relies on firmware to configure >> platform resources, including clocks, interconnects and TLMM. >> The driver requests resources operations over SCMI using power >> and performance protocols. >> >> The SCMI power protocol enables or disables resources like clocks, >> interconnect paths, and TLMM (GPIOs) using runtime PM framework APIs, >> such as resume/suspend, to control power on/off. >> >> The SCMI performance protocol manages I2C frequency, with each >> frequency rate represented by a performance level. The driver uses >> geni_se_set_perf_opp() API to request the desired frequency rate.. >> >> As part of geni_se_set_perf_opp(), the OPP for the requested frequency >> is obtained using dev_pm_opp_find_freq_floor() and the performance >> level is set using dev_pm_opp_set_opp(). >> >> Acked-by: Viken Dadhaniya >> Signed-off-by: Praveen Talari >> --- > > [...] > >> @@ -215,6 +220,7 @@ static void qcom_geni_i2c_conf(struct geni_i2c_dev *gi2c) >> val |= itr->t_low_cnt << LOW_COUNTER_SHFT; >> val |= itr->t_cycle_cnt; >> writel_relaxed(val, gi2c->se.base + SE_I2C_SCL_COUNTERS); >> + return 0; > > ultra nit: a \n before return statements is preferred Sure, will do it in next patch > > [...] > >> static const struct geni_i2c_desc i2c_master_hub = { >> .no_dma_support = true, >> .tx_fifo_depth = 16, >> + .resources_init = geni_i2c_resources_init, >> + .set_rate = qcom_geni_i2c_conf, >> + .power_on = geni_se_resources_activate, >> + .power_off = geni_se_resources_deactivate, >> +}; >> + >> +static const struct geni_i2c_desc sa8255p_geni_i2c = { >> + .resources_init = geni_se_domain_attach, >> + .set_rate = geni_se_set_perf_opp, > > I noticed that because this lacks .power_on/off, the > pinctrl_pm_select_xxx_state() functions are never called. Are the GPIOs > managed through the power/perf domains of the QUP devices too? (I would Yes, GPIOs are managed by Firmware, not by Linux. > assume not since there's a TLMM node in [0]) I don't know the exact reason for this node in DT. Thanks, Praveen Talari > > Konrad > > [0] https://lore.kernel.org/linux-arm-msm/20250422231249.871995-1-quic_djaggi@quicinc.com/