mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Mike Anderson <andmike@us.ibm.com>, Patrick Mochel <mochel@osdl.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Bug with (maybe not *in*) sysfs
Date: Sun, 23 Feb 2003 12:33:19 -0800	[thread overview]
Message-ID: <12070000.1046032398@[10.10.2.4]> (raw)
In-Reply-To: <20030223202401.GA1452@beaverton.ibm.com>

>> This is typically caused by the same object being added twice at the
>> same  level in the hierarchy, which appears to be happening. Is the ips
>> driver  calling pci_register_driver() twice? 
>> 
>> 	-pat
> 
> It was possible in the past that pci_module_init could be called more
> than once with non-unique pci_driver names. It is fixed in the current
> trees, but I do not have the date when it was pushed. Here is some
> context mail links.
> 
> http://marc.theaimsgroup.com/?l=linux-scsi&m=104275858704733&w=2
> 
> http://marc.theaimsgroup.com/?l=linux-scsi&m=104455557710731&w=2

OK, so two similar, but not identical cards using the same driver?
First patch mentioned looks very simple, but won't apply to 2.5.62
There's now just:

   static char ips_hot_plug_name[] = "ips";

   static int __devinit  ips_insert_device(struct pci_dev *pci_dev, const
struct pci_device_id *ent);
   static void __devexit ips_remove_device(struct pci_dev *pci_dev);

   struct pci_driver ips_pci_driver = {
       .name            = ips_hot_plug_name,
       .id_table        = ips_pci_table,
       .probe           = ips_insert_device,
       .remove          = __devexit_p(ips_remove_device),
   };

Second patch looks a little intimidating ... more like a full blown update
of the driver ... I'd rather not go there unless I really have to.

M.


  reply	other threads:[~2003-02-23 20:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-23 19:31 Martin J. Bligh
2003-02-23 19:14 ` Patrick Mochel
2003-02-23 20:24   ` Mike Anderson
2003-02-23 20:33     ` Martin J. Bligh [this message]
2003-02-23 23:45       ` Mike Anderson
2003-02-23 23:50         ` Martin J. Bligh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='12070000.1046032398@[10.10.2.4]' \
    --to=mbligh@aracnet.com \
    --cc=andmike@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mochel@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®