From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753175AbcGKU00 (ORCPT ); Mon, 11 Jul 2016 16:26:26 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:53429 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753136AbcGKU0Y (ORCPT ); Mon, 11 Jul 2016 16:26:24 -0400 From: Arnd Bergmann To: Christoph Hellwig Cc: Jens Axboe , Sagi Grimberg , Jens Axboe , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme-loop: add configfs dependency Date: Mon, 11 Jul 2016 22:29:22 +0200 Message-ID: <12070715.hig6uZ5icx@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160710121417.GA21551@lst.de> References: <20160707090144.3061799-1-arnd@arndb.de> <577E68A5.8080709@kernel.dk> <20160710121417.GA21551@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:O27y0JbbbtCKEIYIit3EjcYx/3bfp7Z871oH0YtICXGJCJS/PkY n8J6DbK08Cb5foen6747g2tTqR962XA2TYghyWpwYx0PB2tS/Q27CuMlmse6x2lxA3rRBRA 8fdzximE4aaPowJTEz3/FA8FcRgILuQqr7rMkclTDz4jPTdigaOET57mI/pcRQWnHIegu5s TXheY1eYgOnsB2ctEGHHQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:cAeOTWR9ZFk=:wAF8JBKopdmBnEzXdonyT6 5ayVRP4zO0KAyQSgjVwtX+doeiPbBN4S0JQfOURXUcn1znwRCKn4m1DHQgk46cZTrE0ZsShp7 vsn0r3wiqPV1Y86M9nIR06ygvwcm7GS4ygZwkCIh6WDjewKDCV8dzDqjs7Y0t6yJHHaAvhd5O LdvuUWTvuSX/bJ7toSWx9qe77YDUBo37TohCSOrb23/sXEuf00cyePLxpYXEqy7LJcX6s+X4V JP0H19kmriM38wR7y3yMwDIkLErFY8t2Rtkn7SlpCl2hXq9W8xEbs/hVt375WwL2JkKNH1g5+ TRZ16QMuCqG0R9zvczMaQgk/CUUvtlWbocpnGqqMTAKbL7A6+KTJWEbX1aqT7Vde3KmY/fULe wf0WsSGBjp7a2umpdxSDKmWLeWEVNYqMEe0WT7lpS+K76mHb2uthgUK+QTn2Dyrkm2DN+doVK lEOJFdKwGrNuQo/vh6CADGN2AedtYrVp2t8Sj6IKk2U/nHUPqQIcm/GSIVAVGkeWk85BreJsk wgMsCcTO1tDgM5p58k0hioMiwY7CsM1AgbLeV4noF4T5LxcSKMxq2SAQA0DE6oB6WgR/Xe/yN qJKkzZwjycaJwM1baYjkzraYoummDH/Pu5tXBvZawfAVe8srB11PyDlXis1XxtEMCqranTIq6 nlZjknnjFynbbDTRnDHFqLTZq0LSZGAMQLFe9sUGIPV7ktpX/vHf537YCqVduvSPxm2guvcTV OQOcSgmIq9rvewEA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, July 10, 2016 2:14:17 PM CEST Christoph Hellwig wrote: > On Thu, Jul 07, 2016 at 08:35:17AM -0600, Jens Axboe wrote: > > Thanks Arnd, applied. > > Actually I think we should replace the select with the depends. In > fact I though I had done that a while ago, but I must have messed it up. Makes sense. I ran into the same problem on NVME_TARGET_RDMA now, which otherwise needs dependencies on both CONFIG_BLOCK and CONFIGFS_FS: warning: (NVME_TARGET_LOOP && NVME_TARGET_RDMA) selects NVME_TARGET which has unmet direct dependencies (BLOCK && CONFIGFS_FS) 0xA002B368 Mon Jul 11 18:00:45 CEST 2016 failed In file included from ../drivers/nvme/target/core.c:16:0: drivers/nvme/target/nvmet.h:222:14: error: field 'inline_bio' has incomplete type struct bio inline_bio; ^~~~~~~~~~ drivers/nvme/target/core.c: In function 'nvmet_async_event_work': drivers/nvme/target/core.c:98:3: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration] kfree(aen); ^~~~~ ../drivers/nvme/target/core.c: In function 'nvmet_ns_enable': ../drivers/nvme/target/core.c:269:13: error: implicit declaration of function 'blkdev_get_by_path' [-Werror=implicit-function-declaration] ns->bdev = blkdev_get_by_path(ns->device_path, FMODE_READ | FMODE_WRITE, Folding in my patch below should address that too. Signed-off-by: Arnd Bergmann diff --git a/drivers/nvme/target/Kconfig b/drivers/nvme/target/Kconfig index 0be9e3d4c352..a5c31cbeb481 100644 --- a/drivers/nvme/target/Kconfig +++ b/drivers/nvme/target/Kconfig @@ -16,8 +16,7 @@ config NVME_TARGET config NVME_TARGET_LOOP tristate "NVMe loopback device support" depends on BLK_DEV_NVME - depends on CONFIGFS_FS - select NVME_TARGET + depends on NVME_TARGET select NVME_FABRICS select SG_POOL help @@ -29,7 +28,7 @@ config NVME_TARGET_LOOP config NVME_TARGET_RDMA tristate "NVMe over Fabrics RDMA target support" depends on INFINIBAND - select NVME_TARGET + depends on NVME_TARGET help This enables the NVMe RDMA target support, which allows exporting NVMe devices over RDMA.