mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: linux-wireless@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	"John W. Linville" <linville@tuxdriver.com>,
	Miles Lane <miles.lane@gmail.com>,
	reinette.chatre@intel.com
Subject: [PATCH] iwlwifi/Kconfg: make IWLWIFI_LEDS invisible
Date: Wed,  2 Apr 2008 12:10:04 -0400	[thread overview]
Message-ID: <1207152604-22973-1-git-send-email-linville@tuxdriver.com> (raw)
In-Reply-To: <a44ae5cd0804020404k295ffc7ew8761cc0901996e20@mail.gmail.com>

Select IWLWIFI_LEDS automatically when either IWL3945_LEDS or
IWL4965_LEDS is selected.  This avoids potential misconfigurations
which lead to build failures for iwl-led.c.

Cc: Miles Lane <miles.lane@gmail.com>
Cc: reinette.chatre@intel.com
Signed-off-by: John w. Linville <linville@tuxdriver.com>
---
 drivers/net/wireless/iwlwifi/Kconfig |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/Kconfig b/drivers/net/wireless/iwlwifi/Kconfig
index 4a5c8c0..8137690 100644
--- a/drivers/net/wireless/iwlwifi/Kconfig
+++ b/drivers/net/wireless/iwlwifi/Kconfig
@@ -3,11 +3,8 @@ config IWLCORE
 	depends on PCI && MAC80211 && WLAN_80211 && EXPERIMENTAL
 
 config IWLWIFI_LEDS
-	bool "Enable LEDS features in iwlwifi driver"
-	depends on IWLCORE && MAC80211_LEDS && LEDS_CLASS
-	---help---
-	  This option enables LEDS for the iwlwifi drivers
-
+	bool
+	default n
 
 config IWLCORE_RFKILL
 	boolean "IWLWIFI RF kill support"
@@ -52,7 +49,8 @@ config IWL4965_HT
 
 config IWL4965_LEDS
 	bool "Enable LEDS features in iwl4965 driver"
-	depends on IWL4965 && IWLWIFI_LEDS
+	depends on IWL4965 && MAC80211_LEDS && LEDS_CLASS
+	select IWLWIFI_LEDS
 	---help---
 	  This option enables LEDS for the iwlwifi drivers
 
@@ -137,6 +135,7 @@ config IWL3945_SPECTRUM_MEASUREMENT
 config IWL3945_LEDS
 	bool "Enable LEDS features in iwl3945 driver"
 	depends on IWL3945 && MAC80211_LEDS && LEDS_CLASS
+	select IWLWIFI_LEDS
 	---help---
 	  This option enables LEDS for the iwl3945 driver.
 
-- 
1.5.3.3


  reply	other threads:[~2008-04-02 16:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-02 11:04 2.6.25-rc8-mm1 -- drivers/net/wireless/iwlwifi/iwl-led.c:184: error: ‘struct iwl_priv’ has no member named ‘last_blink_time’ Miles Lane
2008-04-02 16:10 ` John W. Linville [this message]
2008-04-02 20:15   ` [PATCH] iwlwifi/Kconfg: make IWLWIFI_LEDS invisible Tomas Winkler
2008-04-02 17:52 ` 2.6.25-rc8-mm1 -- drivers/net/wireless/iwlwifi/iwl-led.c:184: error: 'struct iwl_priv' has no member named 'last_blink_time' Chatre, Reinette
2008-04-02 20:13 ` 2.6.25-rc8-mm1 -- drivers/net/wireless/iwlwifi/iwl-led.c:184: error: ‘struct iwl_priv’ has no member named ‘last_blink_time’ Tomas Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1207152604-22973-1-git-send-email-linville@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=miles.lane@gmail.com \
    --cc=reinette.chatre@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®