From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
schwidefsky@de.ibm.com, Ingo Molnar <mingo@elte.hu>,
"David S. Miller" <davem@davemloft.net>,
Tony Luck <tony.luck@intel.com>,
Paul Mackerras <paulus@samba.org>,
Thomas Gleixner <tglx@linutronix.de>,
Paul Mundt <lethal@linux-sh.org>
Subject: Re: [PATCH 1/3] hugetlbfs: architecture header cleanup
Date: Wed, 02 Apr 2008 10:42:56 -0700 [thread overview]
Message-ID: <1207158176.23710.7.camel@nimitz.home.sr71.net> (raw)
In-Reply-To: <1207146415.4980.11.camel@localhost.localdomain>
On Wed, 2008-04-02 at 16:26 +0200, Gerald Schaefer wrote:
>
> include/asm-ia64/hugetlb.h | 21 +++++++++++++++++++
> include/asm-ia64/page.h | 6 -----
> include/asm-powerpc/hugetlb.h | 35 +++++++++++++++++++++++++++++++
> include/asm-powerpc/page_64.h | 7 ------
> include/asm-sh/hugetlb.h | 28 +++++++++++++++++++++++++
> include/asm-sparc64/hugetlb.h | 30 +++++++++++++++++++++++++++
> include/asm-sparc64/page.h | 2 -
> include/asm-x86/hugetlb.h | 28 +++++++++++++++++++++++++
> include/linux/hugetlb.h | 46 ------------------------------------------
The way I read this, you took some arch-independent bits, like
prepare_hugepage_range(), and copied them to several architectures. How
is this a cleanup? Can they really not share common code?
-- Dave
next prev parent reply other threads:[~2008-04-02 17:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-02 14:17 [PATCH 0/3] hugetlbfs: cleanup and new primitives for s390 Gerald Schaefer
2008-04-02 14:26 ` [PATCH 1/3] hugetlbfs: architecture header cleanup Gerald Schaefer
2008-04-02 17:42 ` Dave Hansen [this message]
2008-04-02 19:07 ` Heiko Carstens
2008-04-03 21:43 ` Andrew Morton
2008-04-02 14:29 ` [PATCH 2/3] hugetlbfs: add missing TLB flush to hugetlb_cow() Gerald Schaefer
2008-04-03 21:49 ` Andrew Morton
2008-04-02 14:38 ` [PATCH 3/3] hugetlbfs: common code update for s390 Gerald Schaefer
2008-04-04 16:45 [PATCH 0/3] hugetlbfs: cleanup and new primitives for s390, v3 Gerald Schaefer
2008-04-04 16:49 ` [PATCH 1/3] hugetlbfs: architecture header cleanup Gerald Schaefer
2008-04-08 3:59 ` Andrew Morton
2008-04-09 11:35 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207158176.23710.7.camel@nimitz.home.sr71.net \
--to=dave@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=gerald.schaefer@de.ibm.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®