From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86: fix miscompile
Date: Thu, 03 Apr 2008 09:53:38 -0500 [thread overview]
Message-ID: <1207234418.3048.25.camel@localhost.localdomain> (raw)
This patch local to the x86 tree introduced a fairly obvious compile
fault:
commit f22fc9998497af6c271385e2025e2fe71c6f15b0
Author: Ingo Molnar <mingo@elte.hu>
Date: Wed Apr 2 12:20:18 2008 +0200
x86: allocate FPU context to init task
I've attached the fix below (INIT_THREAD is a #defined initializer, not
an actual structure). However, if you get this tree into linux-next,
they'll do a much better job of shaking out bugs like this than I could.
James
---
diff --git a/include/asm-x86/processor.h b/include/asm-x86/processor.h
index d4686cf..2fad98d 100644
--- a/include/asm-x86/processor.h
+++ b/include/asm-x86/processor.h
@@ -828,7 +828,7 @@ extern union thread_xstate init_xstate;
.sysenter_cs = __KERNEL_CS, \
.io_bitmap_ptr = NULL, \
.fs = __KERNEL_PERCPU, \
- .xstate = &init_xstate;
+ .xstate = &init_xstate, \
}
/*
next reply other threads:[~2008-04-03 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-03 14:53 James Bottomley [this message]
2008-04-03 18:14 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207234418.3048.25.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®