From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757230AbYDDBAZ (ORCPT ); Thu, 3 Apr 2008 21:00:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754924AbYDDBAO (ORCPT ); Thu, 3 Apr 2008 21:00:14 -0400 Received: from e3.ny.us.ibm.com ([32.97.182.143]:38730 "EHLO e3.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751923AbYDDBAN (ORCPT ); Thu, 3 Apr 2008 21:00:13 -0400 Subject: Re: [PATCH 4 of 6] hotplug-memory: use common online_page From: Dave Hansen To: Jeremy Fitzhardinge Cc: KAMEZAWA Hiroyuki , Yasunori Goto , Ingo Molnar , LKML , Christoph Lameter In-Reply-To: <47F57CA0.1000500@goop.org> References: <1207270061.943.21.camel@nimitz.home.sr71.net> <47F57CA0.1000500@goop.org> Content-Type: text/plain Date: Thu, 03 Apr 2008 18:00:05 -0700 Message-Id: <1207270805.943.33.camel@nimitz.home.sr71.net> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2008-04-03 at 17:56 -0700, Jeremy Fitzhardinge wrote: > Dave Hansen wrote: > > This is OK, but I do think the __weak stuff can make it a bit > > counter-intuitive to track down which version is actually getting used. > > Are there any people the currently override that __weak? > > > > If not, we should probably just kill it. > > Yes, x86-32 has a different implementation. I guess we could just make the copies conditional on CONFIG_HIGHMEM and define them both next to each other. It's really a highmem thing more than a per-arch thing. -- Dave