From: Alok Kataria <akataria@vmware.com>
To: len.brown@intel.com
Cc: rui.zhang@intel.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, Daniel Arai <arai@vmware.com>,
Zachary Amsden <zach@vmware.com>
Subject: Re: Fix "buggy BIOS check" when CPUs are hot removed
Date: Mon, 07 Apr 2008 11:55:00 -0700 [thread overview]
Message-ID: <1207594500.5864.31.camel@promb-2n-dhcp158.eng.vmware.com> (raw)
In-Reply-To: <1207352924.6294.29.camel@promb-2n-dhcp158.eng.vmware.com>
[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]
This patch too seems malformed. Resending and also find attached.
Thanks,
Alok
--
Fix "buggy BIOS check" when CPUs are hot added and removed
processor_device_array[pr->id] needs to be set to NULL when removing a
CPU. Else the "buggy BIOS check" in acpi_processor_start mistakenly
fires when a CPU is removed from the system and then later re-added.
Signed-off-by: Alok N Kataria <akataria@vmware.com>
Signed-off-by: Dan Arai <arai@vmware.com>
---
drivers/acpi/processor_core.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/processor_core.c
b/drivers/acpi/processor_core.c
index 61450f4..0f95f26 100644
--- a/drivers/acpi/processor_core.c
+++ b/drivers/acpi/processor_core.c
@@ -828,6 +828,7 @@ static int acpi_processor_remove(struct acpi_device
*device, int type)
}
processors[pr->id] = NULL;
+ processor_device_array[pr->id] = NULL;
kfree(pr);
--
1.5.4
On Fri, 2008-04-04 at 16:48 -0700, Alok Kataria wrote:
> Fixes a BUG in ACPI hotplugging.
>
> processor_device_array[pr->id] needs to be set to NULL when removing a
> CPU. Else the "buggy BIOS check" in acpi_processor_start mistakenly
> fires when a CPU is removed from the system and then later re-added.
>
> Signed-off-by: Alok N Kataria <akataria@vmware.com>
> Signed-off-by: Dan Arai <arai@vmware.com>
>
> ---
> drivers/acpi/processor_core.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/acpi/processor_core.c
> b/drivers/acpi/processor_core.c
> index 61450f4..0f95f26 100644
> --- a/drivers/acpi/processor_core.c
> +++ b/drivers/acpi/processor_core.c
> @@ -828,6 +828,7 @@ static int acpi_processor_remove(struct acpi_device
> *device, int type)
> }
>
> processors[pr->id] = NULL;
> + processor_device_array[pr->id] = NULL;
>
> kfree(pr);
>
[-- Attachment #2: buggy-bios-check-on-cpu-hotplug.patch --]
[-- Type: text/x-patch, Size: 859 bytes --]
Fix "buggy BIOS check" when CPUs are hot added and removed
processor_device_array[pr->id] needs to be set to NULL when removing a
CPU. Else the "buggy BIOS check" in acpi_processor_start mistakenly
fires when a CPU is removed from the system and then later re-added.
Signed-off-by: Alok N Kataria <akataria@vmware.com>
Signed-off-by: Dan Arai <arai@vmware.com>
---
drivers/acpi/processor_core.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
index 61450f4..0f95f26 100644
--- a/drivers/acpi/processor_core.c
+++ b/drivers/acpi/processor_core.c
@@ -828,6 +828,7 @@ static int acpi_processor_remove(struct acpi_device *device, int type)
}
processors[pr->id] = NULL;
+ processor_device_array[pr->id] = NULL;
kfree(pr);
--
1.5.4
next prev parent reply other threads:[~2008-04-07 18:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-04 23:48 Alok Kataria
2008-04-07 18:55 ` Alok Kataria [this message]
2008-04-08 7:03 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207594500.5864.31.camel@promb-2n-dhcp158.eng.vmware.com \
--to=akataria@vmware.com \
--cc=arai@vmware.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®