From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753390AbeAZPBd (ORCPT ); Fri, 26 Jan 2018 10:01:33 -0500 Received: from esa1.dell-outbound.iphmx.com ([68.232.153.90]:4443 "EHLO esa1.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753371AbeAZPBZ (ORCPT ); Fri, 26 Jan 2018 10:01:25 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2GnAQAlQmtah8uZ6ERcGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYQYgQQnB2uCa5kPggJ8hBCEB5BICjeFBAIaggNYFAEBAQEBAQE?= =?us-ascii?q?BAgECEAEBAQoLCQgoL4I4IoJKAQEBBCMEDUUMBAIBCBEEAQEDAiMDAgICHyUBC?= =?us-ascii?q?AgCBAENBQiKFQMVsESBbTqHPw2DDAEBAQEBAQQBAQEBAQEBAQEBAR2BD4NDghW?= =?us-ascii?q?DPgGCeDaCa0QEgXYfFIJdgmUFmhKJRD2QYIR9lDGOJok5gTw2gXNwgnyCVRAMg?= =?us-ascii?q?Wd4i2EqgQqBFwEBAQ?= X-IPAS-Result: =?us-ascii?q?A2GnAQAlQmtah8uZ6ERcGQEBAQEBAQEBAQEBAQcBAQEBAYQ?= =?us-ascii?q?YgQQnB2uCa5kPggJ8hBCEB5BICjeFBAIaggNYFAEBAQEBAQEBAgECEAEBAQoLC?= =?us-ascii?q?QgoL4I4IoJKAQEBBCMEDUUMBAIBCBEEAQEDAiMDAgICHyUBCAgCBAENBQiKFQM?= =?us-ascii?q?VsESBbTqHPw2DDAEBAQEBAQQBAQEBAQEBAQEBAR2BD4NDghWDPgGCeDaCa0QEg?= =?us-ascii?q?XYfFIJdgmUFmhKJRD2QYIR9lDGOJok5gTw2gXNwgnyCVRAMgWd4i2EqgQqBFwE?= =?us-ascii?q?BAQ?= From: X-LoopCount0: from 10.166.132.190 X-IronPort-AV: E=Sophos;i="5.46,416,1511848800"; d="scan'208";a="119601962" X-DLP: DLP_GlobalPCIDSS To: , CC: , , , , , Subject: RE: [PATCH v5] Support intel-vbtn based tablet mode switch Thread-Topic: [PATCH v5] Support intel-vbtn based tablet mode switch Thread-Index: AQHTlpfcH0EtH4Lt+0alVTL+PMoOjaOGP8Ag Date: Fri, 26 Jan 2018 15:01:22 +0000 Message-ID: <1207f9b5b67f404c8a273ad0db661c73@ausx13mpc120.AMER.DELL.COM> References: <1516965688-9286-1-git-send-email-notmart@gmail.com> In-Reply-To: <1516965688-9286-1-git-send-email-notmart@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.242.75] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w0QF1c3U023060 > -----Original Message----- > From: platform-driver-x86-owner@vger.kernel.org [mailto:platform-driver-x86- > owner@vger.kernel.org] On Behalf Of Marco Martin > Sent: Friday, January 26, 2018 5:21 AM > To: linux-kernel@vger.kernel.org > Cc: mjg59@srcf.ucam.org; pali.rohar@gmail.com; dvhart@infradead.org; > andy@infradead.org; bhush94@gmail.com; platform-driver-x86@vger.kernel.org; > Limonciello, Mario ; Marco Martin > ; Limonciello, Mario > Subject: [PATCH v5] Support intel-vbtn based tablet mode switch > > Some laptops such as Dell Inspiron 7000 series have the > tablet mode switch implemented in Intel ACPI, > the events to enter and exit the tablet mode are 0xCC and 0xCD > > CC: platform-driver-x86@vger.kernel.org > CC: Matthew Garrett > CC: "Pali Rohár" > CC: Darren Hart > CC: Mario Limonciello > CC: Andy Shevchenko > > Signed-off-by: Marco Martin > --- > drivers/platform/x86/intel-vbtn.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c > index 58c5ff3..3765c41 100644 > --- a/drivers/platform/x86/intel-vbtn.c > +++ b/drivers/platform/x86/intel-vbtn.c > @@ -26,6 +26,9 @@ > #include > #include > > +/* When NOT in tablet mode, VGBS returns with the flag 0x40 */ > +#define TABLET_MODE_FLAG 0x40 > + > MODULE_LICENSE("GPL"); > MODULE_AUTHOR("AceLan Kao"); > > @@ -42,6 +45,8 @@ static const struct key_entry intel_vbtn_keymap[] = { > { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } }, /* volume-up key > release */ > { KE_KEY, 0xC6, { KEY_VOLUMEDOWN } }, /* volume-down > key press */ > { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } }, /* volume-down key > release */ > + { KE_SW, 0xCC, { .sw = { SW_TABLET_MODE, 1 } } }, /* Tablet mode in */ > + { KE_SW, 0xCD, { .sw = { SW_TABLET_MODE, 0 } } }, /* Tablet mode out */ > { KE_END }, > }; > > @@ -88,6 +93,7 @@ static void notify_handler(acpi_handle handle, u32 event, > void *context) > > static int intel_vbtn_probe(struct platform_device *device) > { > + struct acpi_buffer vgbs_output = { ACPI_ALLOCATE_BUFFER, NULL }; > acpi_handle handle = ACPI_HANDLE(&device->dev); > struct intel_vbtn_priv *priv; > acpi_status status; > @@ -110,6 +116,20 @@ static int intel_vbtn_probe(struct platform_device > *device) > return err; > } > > + status = acpi_evaluate_object(handle, "VGBS", NULL, &vgbs_output); > + /* VGBS being present and returning something means > + * we have a tablet mode switch > + */ > + if (ACPI_SUCCESS(status)) { > + union acpi_object *obj = vgbs_output.pointer; > + > + if (obj && obj->type == ACPI_TYPE_INTEGER) { > + input_report_switch(priv->input_dev, > + > SW_TABLET_MODE, > + !(obj- > >integer.value & TABLET_MODE_FLAG)); > + } > + } > + > status = acpi_install_notify_handler(handle, > ACPI_DEVICE_NOTIFY, > notify_handler, > -- > 2.7.4 Looks good to me now. Reviewed-by: Mario Limonciello