From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761053AbYDPDeR (ORCPT ); Tue, 15 Apr 2008 23:34:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753537AbYDPDeG (ORCPT ); Tue, 15 Apr 2008 23:34:06 -0400 Received: from mx1.suse.de ([195.135.220.2]:40339 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753445AbYDPDeF (ORCPT ); Tue, 15 Apr 2008 23:34:05 -0400 Subject: Re: [PATCH] increment nr_tasks in io_context when CLONE_IO is set From: Nikanth Karthikesan To: Jens Axboe Cc: Linux Kernel Mailing List In-Reply-To: <4804A6CF.BANGALORE.BLR.100.174746A.1.15A79.1@1:7.BANGALORE.BLR.100.0.1.0.1@16> References: <1208231425.27984.9.camel@zero100.blr.novell.com> <4804A6CF.BANGALORE.BLR.100.174746A.1.15A79.1@1:7.BANGALORE.BLR.100.0.1.0.1@16> Content-Type: text/plain Date: Wed, 16 Apr 2008 09:05:11 +0530 Message-Id: <1208316911.1588.0.camel@zero100.blr.novell.com> Mime-Version: 1.0 X-Mailer: Evolution 2.12.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2008-04-15 at 09:24 +0200, Jens Axboe wrote: > On Tue, Apr 15 2008, Nikanth Karthikesan wrote: > > Increment the nr_tasks associated with the io_context when CLONE_IO flag > > is set. > > > > Signed-off-by: Nikanth Karthikesan > > > > -- > > diff --git a/kernel/fork.c b/kernel/fork.c > > index dd249c3..01e843b 100644 > > --- a/kernel/fork.c > > +++ b/kernel/fork.c > > @@ -812,6 +812,7 @@ static int copy_io(unsigned long clone_f > > tsk->io_context = ioc_task_link(ioc); > > if (unlikely(!tsk->io_context)) > > return -ENOMEM; > > + atomic_inc(&tsk->io_context->nr_tasks); > > } else if (ioprio_valid(ioc->ioprio)) { > > tsk->io_context = alloc_io_context(GFP_KERNEL, -1); > > if (unlikely(!tsk->io_context)) > > Fix is correct, however it would be more appropriate in ioc_task_link() > instead. Yes. Thanks. > > diff --git a/include/linux/iocontext.h b/include/linux/iocontext.h > index cac4b36..2b7a118 100644 > --- a/include/linux/iocontext.h > +++ b/include/linux/iocontext.h > @@ -91,8 +91,10 @@ static inline struct io_context *ioc_task_link(struct io_context *ioc) > * if ref count is zero, don't allow sharing (ioc is going away, it's > * a race). > */ > - if (ioc && atomic_inc_not_zero(&ioc->refcount)) > + if (ioc && atomic_inc_not_zero(&ioc->refcount)) { > + atomic_inc(&ioc->nr_tasks); > return ioc; > + } > > return NULL; > } >