mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: vm86 - hide X86_VM_MASK from userland programs
Date: Thu, 24 Apr 2008 09:39:24 +0100	[thread overview]
Message-ID: <1209026364.9212.978.camel@pmac.infradead.org> (raw)
In-Reply-To: <20080424083558.GA7749@cvg>

On Thu, 2008-04-24 at 12:35 +0400, Cyrill Gorcunov wrote:
> X86_VM_MASK is a kernel specific flag so lets hide it from
> userland programs
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>

Since and there's already an #ifdef __KERNEL__ section later on in the
file, and since X86_VM_MASK isn't used before that, I probably would
have been inclined to shift it down there instead of adding a new
#ifdef.

But maybe I should just stop heckling... :)

-- 
dwmw2


  reply	other threads:[~2008-04-24  8:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-24  8:35 Cyrill Gorcunov
2008-04-24  8:39 ` David Woodhouse [this message]
2008-04-24  8:42   ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1209026364.9212.978.camel@pmac.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=gorcunov@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®