From: Johannes Berg <johannes@sipsolutions.net>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: jussi.kivilinna@mbnet.fi, linux-wireless@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wireless: rndis_wlan: modparam_workaround_interval is never below 0.
Date: Thu, 24 Apr 2008 10:57:31 +0200 [thread overview]
Message-ID: <1209027451.3357.49.camel@johannes.berg> (raw)
In-Reply-To: <480F97B5.9030009@tiscali.nl> (sfid-20080423_221109_783456_35B212E0)
[-- Attachment #1: Type: text/plain, Size: 531 bytes --]
On Wed, 2008-04-23 at 22:10 +0200, Roel Kluin wrote:
> priv->param_workaround_interval is unsigned,
> modparam_workaround_interval not.
> the former is never < 0.
> - priv->param_workaround_interval = modparam_workaround_interval;
>
> - if (priv->param_workaround_interval < 0)
> + if (modparam_workaround_interval < 0)
> priv->param_workaround_interval = 500;
> + else
> + priv->param_workaround_interval = modparam_workaround_interval;
Eh, why not make the modparam unsigned and default to 500?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2008-04-24 8:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 20:10 Roel Kluin
2008-04-24 6:16 ` Jussi Kivilinna
2008-04-24 8:57 ` Johannes Berg [this message]
2008-04-24 9:26 ` Jussi Kivilinna
2008-04-24 12:16 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209027451.3357.49.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=12o3l@tiscali.nl \
--cc=jussi.kivilinna@mbnet.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®