mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Walker <dwalker@mvista.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-kernel@vger.kernel.org, Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: Announce: Semaphore-Removal tree
Date: Fri, 25 Apr 2008 13:38:37 -0700	[thread overview]
Message-ID: <1209155917.12461.46.camel@localhost.localdomain> (raw)
In-Reply-To: <20080425170021.GH14990@parisc-linux.org>


On Fri, 2008-04-25 at 11:00 -0600, Matthew Wilcox wrote:
> http://git.kernel.org/?p=linux/kernel/git/willy/misc.git;a=shortlog;h=semaphore-removal
> 

I was reviewing your patches, and I don't like the semaphore to spinlock
changes.. There's no reason to start adding spinlocks, unless it's
really performance sensitive which none of those places are.. 

Also the ps3-gelic changes for instance is three locks in one patch. It
should be one lock per patch .. I have a broken out conversion for gelic
which I was going to submit in my next round ..

There's also a number of other people doing these , so you might want to
hold off on doing more unless you know they aren't already completed ..

Daniel


  parent reply	other threads:[~2008-04-25 20:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-25 17:00 Matthew Wilcox
2008-04-25 20:24 ` Daniel Walker
2008-04-25 20:38 ` Daniel Walker [this message]
2008-04-25 21:12   ` Christoph Hellwig
2008-04-25 21:22     ` Daniel Walker
2008-04-26  9:30       ` Christoph Hellwig
2008-04-26 13:39         ` Peter Zijlstra
2008-04-26 13:44           ` Christoph Hellwig
2008-04-26 14:04             ` Peter Zijlstra
2008-04-28  4:59             ` David Chinner
2008-04-26 13:54 ` Stephen Rothwell
2008-04-26 15:59   ` Matthew Wilcox
2008-04-26 16:43     ` Stephen Rothwell
2008-04-28  5:10 ` David Chinner
2008-04-28 12:20   ` Matthew Wilcox
2008-04-29  0:09     ` David Chinner
2008-04-29  2:35       ` Matthew Wilcox
2008-04-29  3:56         ` David Chinner
2008-04-30 10:21           ` Matthew Wilcox
2008-04-30 10:06       ` Matthew Wilcox
2008-04-30 11:01         ` David Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1209155917.12461.46.camel@localhost.localdomain \
    --to=dwalker@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome