mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Nizette <bn@niasdigital.com>
To: David Brownell <david-b@pacbell.net>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, bn@niasdigital.com
Subject: [PATCH] Give gpiolib an implementation of gpio_is_valid()
Date: Sat, 26 Apr 2008 21:03:01 +1000	[thread overview]
Message-ID: <1209207781.3756.120.camel@moss.renham> (raw)


Platforms which use generic (NOP) gpio routines get an implementation of
gpio_is_valid() (in linux/gpio.h) but the people who actually use gpio
don't get one.  Roll an implementation for gpiolib based on
gpio_request(); this ought to do for most people.

Signed-off-by: Ben Nizette <bn@niasdigital.com>
---
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index d8db2f8..137688c 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -158,6 +158,34 @@ int gpiochip_remove(struct gpio_chip *chip)
 }
 EXPORT_SYMBOL_GPL(gpiochip_remove);
 
+/**
+ * gpio_is_valid() - check if a gpio number actually corresponds to a gpio
+ * @number: the gpio number to test
+ *
+ * Returns 1 if the gpio is valid, 0 otherwise.
+ */
+int gpio_is_valid(int number)
+{
+	struct gpio_desc	*desc;
+	int			ret = 0;
+	unsigned long		flags;
+
+	spin_lock_irqsave(&gpio_lock, flags);
+
+	if (number >= ARCH_NR_GPIOS)
+		goto done;
+
+	desc = &gpio_desc[number];
+	if (desc->chip == NULL)
+		goto done;
+
+	ret = 1;
+
+done:
+	spin_unlock_irqrestore(&gpio_lock, flags);
+	return ret;
+}
+EXPORT_SYMBOL_GPL(gpio_is_valid);
 
 /* These "optional" allocation calls help prevent drivers from stomping
  * on each other, and help provide better diagnostics in debugfs.
diff --git a/include/asm-generic/gpio.h b/include/asm-generic/gpio.h
index f29a502..8c26523 100644
--- a/include/asm-generic/gpio.h
+++ b/include/asm-generic/gpio.h
@@ -75,6 +75,8 @@ extern int __must_check gpiochip_remove(struct gpio_chip *chip);
 /* Always use the library code for GPIO management calls,
  * or when sleeping may be involved.
  */
+extern int gpio_is_valid(int number);
+
 extern int gpio_request(unsigned gpio, const char *label);
 extern void gpio_free(unsigned gpio);
 


             reply	other threads:[~2008-04-26 11:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-26 11:03 Ben Nizette [this message]
2008-04-26 16:12 ` David Brownell
2008-04-26 23:28   ` Ben Nizette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1209207781.3756.120.camel@moss.renham \
    --to=bn@niasdigital.com \
    --cc=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®