From: "Denis V. Lunev" <den@openvz.org>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, "Denis V. Lunev" <den@openvz.org>,
Alexey Dobriyan <adobriyan@openvz.org>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: [PATCH 1/12] sunrpc: assign PDE->data before gluing PDE into /proc tree
Date: Tue, 29 Apr 2008 15:13:11 +0400 [thread overview]
Message-ID: <1209467602-20001-1-git-send-email-den@openvz.org> (raw)
In-Reply-To: <1209467538.29647.11.camel@iris.sw.ru>
Simply replace proc_create and further data assigned with proc_create_data.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Cc: Alexey Dobriyan <adobriyan@openvz.org>
Cc: Eric W. Biederman <ebiederm@xmission.com>
---
net/sunrpc/cache.c | 15 ++++++---------
net/sunrpc/stats.c | 8 +-------
2 files changed, 7 insertions(+), 16 deletions(-)
diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
index d75530f..c996671 100644
--- a/net/sunrpc/cache.c
+++ b/net/sunrpc/cache.c
@@ -316,31 +316,28 @@ static int create_cache_proc_entries(struct cache_detail *cd)
cd->proc_ent->owner = cd->owner;
cd->channel_ent = cd->content_ent = NULL;
- p = proc_create("flush", S_IFREG|S_IRUSR|S_IWUSR,
- cd->proc_ent, &cache_flush_operations);
+ p = proc_create_data("flush", S_IFREG|S_IRUSR|S_IWUSR,
+ cd->proc_ent, &cache_flush_operations, cd);
cd->flush_ent = p;
if (p == NULL)
goto out_nomem;
p->owner = cd->owner;
- p->data = cd;
if (cd->cache_request || cd->cache_parse) {
- p = proc_create("channel", S_IFREG|S_IRUSR|S_IWUSR,
- cd->proc_ent, &cache_file_operations);
+ p = proc_create_data("channel", S_IFREG|S_IRUSR|S_IWUSR,
+ cd->proc_ent, &cache_file_operations, cd);
cd->channel_ent = p;
if (p == NULL)
goto out_nomem;
p->owner = cd->owner;
- p->data = cd;
}
if (cd->cache_show) {
- p = proc_create("content", S_IFREG|S_IRUSR|S_IWUSR,
- cd->proc_ent, &content_file_operations);
+ p = proc_create_data("content", S_IFREG|S_IRUSR|S_IWUSR,
+ cd->proc_ent, &content_file_operations, cd);
cd->content_ent = p;
if (p == NULL)
goto out_nomem;
p->owner = cd->owner;
- p->data = cd;
}
return 0;
out_nomem:
diff --git a/net/sunrpc/stats.c b/net/sunrpc/stats.c
index c6061a4..50b049c 100644
--- a/net/sunrpc/stats.c
+++ b/net/sunrpc/stats.c
@@ -224,16 +224,10 @@ EXPORT_SYMBOL_GPL(rpc_print_iostats);
static inline struct proc_dir_entry *
do_register(const char *name, void *data, const struct file_operations *fops)
{
- struct proc_dir_entry *ent;
-
rpc_proc_init();
dprintk("RPC: registering /proc/net/rpc/%s\n", name);
- ent = proc_create(name, 0, proc_net_rpc, fops);
- if (ent) {
- ent->data = data;
- }
- return ent;
+ return proc_create_data(name, 0, proc_net_rpc, fops, data);
}
struct proc_dir_entry *
--
1.5.3.rc5
next prev parent reply other threads:[~2008-04-29 11:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 11:12 [PATCH 0/12] Further PDE->data assignments cleanups Denis V. Lunev
2008-04-29 11:13 ` Denis V. Lunev [this message]
2008-05-02 9:44 ` [PATCH 1/12] sunrpc: assign PDE->data before gluing PDE into /proc tree David Miller
2008-04-29 11:13 ` [PATCH 2/12] netfilter: " Denis V. Lunev
2008-05-02 9:45 ` David Miller
2008-04-29 11:13 ` [PATCH 3/12] net: " Denis V. Lunev
2008-05-02 9:46 ` David Miller
2008-04-29 11:13 ` [PATCH 4/12] ipv6: " Denis V. Lunev
2008-05-02 9:47 ` David Miller
2008-04-29 11:13 ` [PATCH 5/12] atm: " Denis V. Lunev
2008-05-02 11:08 ` David Miller
2008-04-29 11:13 ` [PATCH 6/12] vlan: " Denis V. Lunev
2008-05-02 11:09 ` David Miller
2008-04-29 11:13 ` [PATCH 7/12] cciss: " Denis V. Lunev
2008-04-29 15:26 ` Miller, Mike (OS Dev)
2008-04-29 11:13 ` [PATCH 8/12] powerpc: " Denis V. Lunev
2008-04-29 11:13 ` [PATCH 9/12] ipv4: " Denis V. Lunev
2008-05-02 11:10 ` David Miller
2008-07-12 3:12 ` Stoyan Gaydarov
2008-07-12 3:42 ` Eric W. Biederman
2008-07-12 14:55 ` Denis V. Lunev
2008-04-29 11:13 ` [PATCH 10/12] netfilter: assign PDE->fops " Denis V. Lunev
2008-05-02 11:11 ` David Miller
2008-04-29 11:13 ` [PATCH 11/12] netfilter: assign PDE->data " Denis V. Lunev
2008-04-29 12:01 ` Patrick McHardy
2008-05-02 11:12 ` David Miller
2008-04-29 11:13 ` [PATCH 12/12] netns: assign PDE->data before gluing entry " Denis V. Lunev
2008-05-02 11:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209467602-20001-1-git-send-email-den@openvz.org \
--to=den@openvz.org \
--cc=adobriyan@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome