From: Tom Rix <trix@redhat.com>
To: Michael Walle <michael@walle.cc>
Cc: srinivas.kandagatla@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvmem: layouts: sl28vpd: set varaiable sl28vpd_layout storage-class-specifier to static
Date: Wed, 5 Apr 2023 05:25:29 -0700 [thread overview]
Message-ID: <120b6729-c329-ea4d-2f69-f8bc5c2925bf@redhat.com> (raw)
In-Reply-To: <cce4b409e20b073431b44a44f7f0a614@walle.cc>
On 4/4/23 12:09 PM, Michael Walle wrote:
> Am 2023-04-04 18:36, schrieb Tom Rix:
>> smatch reports
>> drivers/nvmem/layouts/sl28vpd.c:144:21: warning: symbol
>> 'sl28vpd_layout' was not declared. Should it be static?
>>
>> This variable is only used in one file so it should be static.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>
> Fixes tag?
>
I am cleaning all of the similar reports by smatch, there is a couple
hundred.
Because the code works as-is, I do not consider them broken and needing
fixes tags.
However I do not mind adding then if they are required.
Tom
> Reviewed-by: Michael Walle <michael@walle.cc>
>
> -michael
>
prev parent reply other threads:[~2023-04-05 12:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 16:36 Tom Rix
2023-04-04 19:09 ` Michael Walle
2023-04-05 12:25 ` Tom Rix [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=120b6729-c329-ea4d-2f69-f8bc5c2925bf@redhat.com \
--to=trix@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®