From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFE9FC43381 for ; Wed, 27 Mar 2019 14:56:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 995362082F for ; Wed, 27 Mar 2019 14:56:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="dGxWHqMY"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="YIHx5LHG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728849AbfC0O4F (ORCPT ); Wed, 27 Mar 2019 10:56:05 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:56756 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727488AbfC0O4F (ORCPT ); Wed, 27 Mar 2019 10:56:05 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id AC82360A0A; Wed, 27 Mar 2019 14:56:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1553698564; bh=TQt9HC+tr1uEQzkbJoLeoLoHRM/F3bRwChMrVh9KkDo=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=dGxWHqMYpujb5nyYxjspPxXMuuobnoXSpUJJ7v9u5adPm/yyNVsqBjy5hf0TqVGG/ lK8JJhbPnK61WPrJejeTd1DLDmmWJuSB5t8WOp/2qNJdg9GBXgzyUxj+rRq5jgVTNg vn3CqsCaRNSlE2HzED1mfBBqWNWS0nV56GCdG2u8= Received: from [10.204.79.83] (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mojha@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 458E2605A2; Wed, 27 Mar 2019 14:55:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1553698562; bh=TQt9HC+tr1uEQzkbJoLeoLoHRM/F3bRwChMrVh9KkDo=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=YIHx5LHG8wJzEsMn8ENa0tFIY+gz2WonAaPrxOVta7k6fSafl3ipos8+xprLN9Xfd 4zw557+MRkueCPCKUgnz5Us74aaxAMjva0LuWcmDzgN7ecPCxrRivz61XU7k3UGR1w wSeROKV2itDW+umJZLIXulZ6A8IwaebpjZsJmkjI= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 458E2605A2 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mojha@codeaurora.org Subject: Re: [PATCH v3] dccp: Fix memleak in __feat_register_sp To: Yue Haibing , davem@davemloft.net, gerrit@erg.abdn.ac.uk Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, dccp@vger.kernel.org References: <20190325024106.10808-1-yuehaibing@huawei.com> From: Mukesh Ojha Message-ID: <120ffaa7-0e53-7a19-7fbf-898275ff3dab@codeaurora.org> Date: Wed, 27 Mar 2019 20:25:57 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <20190325024106.10808-1-yuehaibing@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/25/2019 8:11 AM, Yue Haibing wrote: > From: YueHaibing > > If dccp_feat_push_change fails, we forget free the mem > which is alloced by kmemdup in dccp_feat_clone_sp_val. > > Reported-by: Hulk Robot > Fixes: e8ef967a54f4 ("dccp: Registration routines for changing feature values") > Signed-off-by: YueHaibing Reviewed-by: Mukesh Ojha -Mukesh > --- > v3: fix compile issue, sorry for this again > v2: kfree 'val --> 'fval' > --- > net/dccp/feat.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/net/dccp/feat.c b/net/dccp/feat.c > index f227f00..db87d9f 100644 > --- a/net/dccp/feat.c > +++ b/net/dccp/feat.c > @@ -738,7 +738,12 @@ static int __feat_register_sp(struct list_head *fn, u8 feat, u8 is_local, > if (dccp_feat_clone_sp_val(&fval, sp_val, sp_len)) > return -ENOMEM; > > - return dccp_feat_push_change(fn, feat, is_local, mandatory, &fval); > + if (dccp_feat_push_change(fn, feat, is_local, mandatory, &fval)) { > + kfree(fval.sp.vec); > + return -ENOMEM; > + } > + > + return 0; > } > > /**