From: Bryan Wu <cooloney@kernel.org>
To: me@felipebalbi.com, david-b@pacbell.net, tony@atomide.com
Cc: linux-omap@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Bryan Wu <cooloney@kernel.org>,
Sonic Zhang <sonic.zhang@analog.com>
Subject: [PATCH 2/2] MUSB: Real fix bug 4 usb bugs found on Blackfin
Date: Sat, 17 May 2008 19:01:21 +0800 [thread overview]
Message-ID: <1211022081-27298-3-git-send-email-cooloney@kernel.org> (raw)
In-Reply-To: <1211022081-27298-1-git-send-email-cooloney@kernel.org>
- USB-IDE
http://blackfin.uclinux.org/gf/project/linux-kernel/tracker/?action=TrackerItemEdit&tracker_item_id=3789
- 30G iPod
http://blackfin.uclinux.org/gf/project/linux-kernel/tracker/?action=TrackerItemEdit&tracker_item_id=3806
- USB to CF/SD card reader
http://blackfin.uclinux.org/gf/project/linux-kernel/tracker/?action=TrackerItemEdit&tracker_item_id=3790
http://blackfin.uclinux.org/gf/project/linux-kernel/tracker/?action=TrackerItemEdit&tracker_item_id=3807
Sonic found, when we got STALL, we should clear the toggle.
Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
---
drivers/usb/musb/musb_host.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
index 535922d..806c479 100644
--- a/drivers/usb/musb/musb_host.c
+++ b/drivers/usb/musb/musb_host.c
@@ -1473,7 +1473,7 @@ void musb_host_rx(struct musb *musb, u8 epnum)
(void) musb->dma_controller->channel_abort(dma);
xfer_len = dma->actual_len;
}
- musb_h_flush_rxfifo(hw_ep, 0);
+ musb_h_flush_rxfifo(hw_ep, MUSB_RXCSR_CLRDATATOG);
musb_writeb(epio, MUSB_RXINTERVAL, 0);
done = true;
goto finish;
--
1.5.5
next prev parent reply other threads:[~2008-05-17 11:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-17 11:01 [PATCH 0/2] MUSB: 2 patches to fix some bug " Bryan Wu
2008-05-17 11:01 ` [PATCH 1/2] MUSB: fix bug - since 2.6.24 urb API changed, giveback function return wrong status Bryan Wu
2008-05-17 11:01 ` Bryan Wu [this message]
2008-05-19 15:16 ` [PATCH 2/2] MUSB: Real fix bug 4 usb bugs found on Blackfin Gadiyar, Anand
2008-05-19 15:28 ` Mike Frysinger
2008-05-17 14:37 ` [PATCH 0/2] MUSB: 2 patches to fix some bug " David Brownell
2008-05-19 6:39 ` Bryan Wu
2008-05-19 7:49 ` Felipe Balbi
2008-05-19 8:05 ` Bryan Wu
2008-05-21 15:50 ` Tony Lindgren
2008-05-21 17:14 ` David Brownell
2008-05-21 19:06 ` Felipe Balbi
2008-05-21 20:04 ` David Brownell
2008-05-21 20:10 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1211022081-27298-3-git-send-email-cooloney@kernel.org \
--to=cooloney@kernel.org \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=me@felipebalbi.com \
--cc=sonic.zhang@analog.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®