From: David Woodhouse <dwmw2@infradead.org>
To: Bernie Innocenti <bernie@codewiz.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
ext3-users@redhat.com, ext2-devel@lists.sourceforge.net,
Stefano Fedrigo <aleph@develer.com>
Subject: Re: ext3_dx_add_entry: Directory index full!
Date: Sun, 18 May 2008 16:39:39 +0100 [thread overview]
Message-ID: <1211125179.21380.2.camel@pmac.infradead.org> (raw)
In-Reply-To: <48304CE2.1090808@codewiz.org>
On Sun, 2008-05-18 at 17:36 +0200, Bernie Innocenti wrote:
>
>
> static inline unsigned dx_root_limit (struct inode *dir, unsigned
> infosize)
> {
> unsigned entry_space = dir->i_sb->s_blocksize -
> EXT3_DIR_REC_LEN(1) -
> EXT3_DIR_REC_LEN(2) - infosize;
> return 0? 20: entry_space / sizeof(struct dx_entry);
> }
>
> Am I reading the above code correctly? Why does it always return
> 20 no matter what?
It doesn't. "condition?A:B" will return A if the condition is _true_,
which it isn't.
--
dwmw2
next prev parent reply other threads:[~2008-05-18 15:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-18 15:36 Bernie Innocenti
2008-05-18 15:38 ` Bernie Innocenti
2008-05-18 18:32 ` Jan Engelhardt
2008-05-18 21:04 ` Theodore Tso
2008-05-19 0:58 ` Bernie Innocenti
2008-05-18 15:39 ` David Woodhouse [this message]
2008-05-18 15:44 ` Bernie Innocenti
2008-05-18 16:24 ` Theodore Tso
2008-05-18 23:01 ` Stefano Fedrigo
2008-05-19 0:49 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1211125179.21380.2.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=aleph@develer.com \
--cc=bernie@codewiz.org \
--cc=ext2-devel@lists.sourceforge.net \
--cc=ext3-users@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®