From: Jiri Slaby <jirislaby@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: adobriyan@gmail.com, "Dave Young" <hidave.darkstar@gmail.com>,
linux-kernel@vger.kernel.org, Mingming Cao <cmm@us.ibm.com>,
Jiri Slaby <jirislaby@gmail.com>
Subject: ext4-mm-delalloc-ext4-lock-reverse-fix
Date: Mon, 19 May 2008 17:24:47 +0200 [thread overview]
Message-ID: <1211210687-4212-1-git-send-email-jirislaby@gmail.com> (raw)
In-Reply-To: <20080519002919.1f8f21f6.akpm@linux-foundation.org>
Andrew Morton <akpm@linux-foundation.org> wrote:
> On Mon, 19 May 2008 15:15:09 +0800 "Dave Young" <hidave.darkstar@gmail.com> wrote:
>
> > Hi,
> >
> > With 2.6.26-rc2-mm1 I need to sync frequently. It's not normal as my
> > understanding.
> >
> > 1. scp a big file from a lan server. Firstly the speed is about 8M/s,
> > but the speed will slow down to 100K/s at last. After I exec "sync",
> > the speed will restore.
> >
> > Is this a known issue?
> >
>
> Yes, probably related to the "mkfs takes forever" problem. I haven't
> looked into it yet. Nor has anyone else afaik.
Absolutely not sure what this breaks in ext4, but fixes the problem for me:
---
mm/page-writeback.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 040bc7c..789b6ad 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -881,7 +881,7 @@ int write_cache_pages(struct address_space *mapping,
pagevec_init(&pvec, 0);
if (wbc->range_cyclic) {
index = mapping->writeback_index; /* Start from prev offset */
- end = wbc->range_end >> PAGE_CACHE_SHIFT;
+ end = -1;
} else {
index = wbc->range_start >> PAGE_CACHE_SHIFT;
end = wbc->range_end >> PAGE_CACHE_SHIFT;
--
1.5.4.5
next prev parent reply other threads:[~2008-05-19 15:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-19 7:15 [2.6.26-rc2-mm1] sync to speed up? Dave Young
2008-05-19 7:29 ` Andrew Morton
2008-05-19 15:24 ` Jiri Slaby [this message]
2008-05-19 17:54 ` ext4-mm-delalloc-ext4-lock-reverse-fix Mingming Cao
2008-05-19 20:37 ` ext4-mm-delalloc-ext4-lock-reverse-fix Alexey Dobriyan
2008-05-20 2:16 ` ext4-mm-delalloc-ext4-lock-reverse-fix Dave Young
2008-05-19 23:05 ` [2.6.26-rc2-mm1] sync to speed up? Theodore Tso
2008-05-20 2:14 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1211210687-4212-1-git-send-email-jirislaby@gmail.com \
--to=jirislaby@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cmm@us.ibm.com \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®