Re: [RFC][Patch 1/4]integrity: TPM internel kernel interface

[Mimi Zohar <zohar@linux.vnet.ibm.com>]

On Thu, 2008-05-22 at 17:05 +0200, Pavel Machek wrote:
> On Wed 2008-05-21 11:54:16, Mimi Zohar wrote:
> > This is a request for comments for a redesign of the integrity patches.
> > This patchset contains 4 patches.
> > 	Patch 1/4 integrity: TPM internal kernel interface
> > 	Patch 2/4 integrity: special fs magic
> > 	Patch 3/4 integrity: Linux Integrity Module(LIM)
> > 	Patch 4/4 integrity: IMA as an integrity service provider
> >  
> > Resubmitting integrity-tpm-internal-kernel-interface.patch, which
> > was previously Signed-off-by Kylene Hall.
> > 
> > Adds the following support: 
> > - internal kernel interface to transmit TPM commands
> > - reading a pcr value
> > - extending a pcr value
> > - lookup the tpm_chip for given chip number and type
> > 
> > Signed-off-by: Mimi Zohar <zohar@us.ibm.com>
> 
> >  /*
> > - * Returns max number of jiffies to wait
> > + * tpm_calc_ordinal_duration - returns max number of jiffies to wait
> >   */
> > -unsigned long tpm_calc_ordinal_duration(struct tpm_chip *chip,
> > -					   u32 ordinal)
> > +unsigned long tpm_calc_ordinal_duration(struct tpm_chip *chip, u32 ordinal)
> 
> Please don't mix real changes and cleanups... and lots of your changes
> are just cleanups.
> 
> > @@ -544,7 +549,7 @@ duration:
> >  	data[TPM_CAP_SUBCAP_IDX] = TPM_CAP_PROP_TIS_DURATION;
> >  
> >  	rc = transmit_cmd(chip, data, sizeof(data),
> > -			"attempting to determine the durations");
> > +			  "attempting to determine the durations");
> >  	if (rc)
> >  		return;
> >
> 
> ...like this.
> 									Pavel

Ok.  Will separate the changes, from the scripts/Lindent cleanups. 

Mimi