From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A38E175A64 for ; Sat, 13 Jun 2026 15:00:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781362824; cv=none; b=g3PKGVXz7Ui6vLKgOUq2y64Ezn7rIokD3TjQDuOYISFxd/uE7mKusOw0i/MNbmmpyUuWbFexeI67A1xM4rsUPREbntozMLLOitLqlEelTTYv5GpIdsICXEZE2tMMVIj6F1lOVysHL4xdeK700N0na6fkCVYRz38gs/DVacUyq5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781362824; c=relaxed/simple; bh=erKQosPIqdaOgd0Q0tA2hppl0d35KiNWcE7aZoeTRr4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CWuI4Jb/FAINA2uwscRxfMq0xeQb78k4hoUR/7EdawlglsBlz2VBjPCN6Mo8VKw8Woqa+Qvxgp9yk1gXS0OC8juLxFwx89fp/XFGP6WAgaUyl7d3zmtQe+nWQTiArmyrqSoUFzp7XjW+W4c7Ol7UXI43lSXbrCTzgrFVb6QHj2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XIchbEHr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gN5aboJz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XIchbEHr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gN5aboJz" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65DBDglX2280333 for ; Sat, 13 Jun 2026 15:00:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ngRx84rbTESR9X5O9KJfzCIqFTf5hrTxjIsBChnF2Vk=; b=XIchbEHrqfMcEWp2 htoMnkp3IK5LlTU8WXS1tP5LDcKA+2LsdwFHTmvdeLaksjAxQmhPQjCzExUgFmqz p9lYPqliJC3U4gmfA2SOqk0+FRITRz+uShizeDZEjssGVKYA4MjyKUA5OyqqbsE4 qvcp5+b8uOPORiFG09y1nCq/bqPtn57VZylZX85DE3wR18wmtcggcb8DSs6bRZvg q4oMJmnP49leDB0mibuuJyngbBEl8c1/9xzTAzQg4PYmZYDuFk7udbf6XyGjiC4g 3jBntAhb5Wpb1gru6JV81yvottffuBZdbuLiKaf0GaYejFDWZzOs0+/4pF5Uy0Fr 7Qax3A== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ery9f9ccs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 13 Jun 2026 15:00:22 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c85a2c305d0so964397a12.1 for ; Sat, 13 Jun 2026 08:00:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781362822; x=1781967622; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ngRx84rbTESR9X5O9KJfzCIqFTf5hrTxjIsBChnF2Vk=; b=gN5aboJzBN6DQqLchVTp2NaPUJgbPIK75q+3HMogiJWNqkxyUW6HBufxYMb8JSfpPA 8VQ2s599BuxPkjQThTyn2VlBSY8db99sBqgxI31pD4AavyKoJFIY4aWj4juJOAWMHodr xmAb+7ipaO1XAu0+Kx/dlEPxhwFSDX7TrIybvwLikYHR+sBiSQ4tEcY2nmdEOVGtgm0g T0ModerSn1w0vGqVkMKpbkCSTwbEHkVzpixgF+/Yqy7QcsFb++l1vGtDQo0EYxK9lt1o 7FNjsG61sj44c/868SsPwfv3xRb1HK46kN6v0x6PnCe0O+3Kw2156/euAtoAaC4iOm3b LrDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781362822; x=1781967622; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ngRx84rbTESR9X5O9KJfzCIqFTf5hrTxjIsBChnF2Vk=; b=N0fFYXJNL8vJqetRryk4fOGOpN3aziKr3rCXyg+NczW4P+PzULDNQGi1+BDGoVFBKh m+64WYruBDpsoAvR2U57MBPzB+Ij6RYEjgBF6CwM295wY3h1BolJ6dl/SU/I7lP5SbeJ C+bHgsNY9vbJxFIA09inkm6QzHypIcDT0Ko7UOy0W3jilWAymJcNTdb51rc4Aen19Gsa Du1FL+kssKN8X5BlnFxFjTk8mazKnDxZ+Cq8qnB2rle+xFCoav7wLylUTdo6aqieVGvg lScZs2gIXTrBhyvCJkGsEXQmpuO/7ehMZQilujdeVW/mFsPKjK0CA1j7m2FCwMBr1uSl NE+A== X-Forwarded-Encrypted: i=1; AFNElJ9CL2RI118HU0xlXeBCST11vceUjSFZ5Pq4DCpCqVzQ7pTJIJ0E7w6bd2Fs2rQmksDbzPr6vJYi1kk+k2s=@vger.kernel.org X-Gm-Message-State: AOJu0YwIePiFQDAbNzCk6LuYNDjqzalLquUlq1Nz6vyeAuDqZ7Giu7nj psMqwnY2I0C5ujbtXmEpKqMxsIo3MjYlM2B2lAYXGUeXjnZjYY7WUlgINwio9Wtb8h4F1K0K1qF wkkaC7AUc6mghapaJHcwDq16h1hOn/1h0aENtsJW+JzgkZR9mnwUJyz1JAO267CRl8UA= X-Gm-Gg: Acq92OERRnoJzQ2FGCifUDa0T8L5qpE6g7g+o8iGWY8dPiUS7/HUgf327BAZ3uxYuWz MkXeY1FSxkw7BWSuX+0uun+HlYqJN8UiY/GntQk5Mggamzt6wKEBijcIQWN6qwUpQeFgu54u5IY WBWGV3RR8fClYSrv+OruukNcrFj6hUW21h9mwi9ue6Ldbb7tesw2IgTzRlxmVaSUUpzA3Y39BuG Lq6x4Ed4NybcVgZzuXwVELM+/+e9sfyoc+53S0a9gbo/QHimiKKbUqi9P91UBDG+2C9r+QH+ghC IpLmgIF6QdK8jTSRVivxb26qy4Mlu7+Gx8/GcuNlW4vsbmbcWkwWgsbWCYabIHPV+Xb1A6iYjMh Q4sYqy7kMGuCK74gAqAkZX1DYpkhICxobLnKGlpmPXPETK16cR9qvNeF7Rw6cfN4yDTPkFVjbPD R1Tahwb9DixS2nBOgD X-Received: by 2002:a05:6a21:1519:b0:3b4:b26e:bab2 with SMTP id adf61e73a8af0-3b783b22db0mr8102219637.2.1781362821854; Sat, 13 Jun 2026 08:00:21 -0700 (PDT) X-Received: by 2002:a05:6a21:1519:b0:3b4:b26e:bab2 with SMTP id adf61e73a8af0-3b783b22db0mr8102152637.2.1781362821213; Sat, 13 Jun 2026 08:00:21 -0700 (PDT) Received: from [10.133.33.24] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c866325d156sm4733343a12.13.2026.06.13.08.00.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Jun 2026 08:00:20 -0700 (PDT) Message-ID: <12116e07-040c-4536-958a-d55d04d163c8@oss.qualcomm.com> Date: Sat, 13 Jun 2026 23:00:16 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] cpufreq: powernow-k6: replace symbolic permissions with octal To: Jack Lee , rafael@kernel.org, viresh.kumar@linaro.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, zhongqiu.han@oss.qualcomm.com References: <20260612231612.206356-1-skunkolee@gmail.com> Content-Language: en-US From: Zhongqiu Han In-Reply-To: <20260612231612.206356-1-skunkolee@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEzMDE1NCBTYWx0ZWRfXwbEgxoYpJOS0 3rZ51Tv+U7E2pROQC9b0tYLgHLw66IJqzFDrQ/OjR0a/9L5m3Q7nr9nMoCbXFS+7FvWSChjMbqO qqYdPPCacvojMFQRmEK644ZpoqBblaATqd9StYAt7XWxGvPGaNWSPAQWFL6MS4ruR1XX7laS0p5 024r8csvrqVgDN79NdVAJYnco2HuB4BGYuVZcA301KASLv5dLwNSH4Jc73zFdvAbVhIis0HeUAn pi6gFoQm4d8NqWj+uDXqmz4G9KphlJaEW5ctT5XoxWXi8P/O53ZWFaRfcr9tM40eu+jJGj2mcig fg9uJJ5xNKewaDBw0T1nTqZAQcHjb3/jYQOKA/Yk1cSqrFrwPv6dV1otUm7ISakSnZAGV2UoPdH vxGf6+JwjrSlOYGdl8ddpqPhmRVVKNwb1BCLvdtNLPiNNR4M0wyybBu5WnAMvWzFAA/+cpW1O8f zOgDgDRfyMTbNM65CWQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEzMDE1NCBTYWx0ZWRfX99V2o27D4KqR vHHxP/7Kd5gA8qXHBwAajYGXdTSjrQNmpI72e10fFjG7LW9BVHenXTFzZgoeh4WPJDqkkry6xbW LJmtXO+YXd1sYoa4GboG+xdItdLghic= X-Proofpoint-GUID: EUP5llAMwVh2atfelGsQIaz2nEfKuX6d X-Proofpoint-ORIG-GUID: EUP5llAMwVh2atfelGsQIaz2nEfKuX6d X-Authority-Analysis: v=2.4 cv=ULvt2ify c=1 sm=1 tr=0 ts=6a2d7086 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=crW7i2NR9CvPMl2r3TUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-13_02,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 phishscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 malwarescore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606130154 On 6/13/2026 7:16 AM, Jack Lee wrote: > Symbolic permissions S_IRUGO are deprecated in favor of octal > permissions. Replace S_IRUGO with 0444. Hi Jack, Thanks for the patch, the change itself looks reasonable. However, I'm not sure whether this cleanup alone is compelling enough for merge. It might be worth clarifying the commit message, though — as far as I know, S_IRUGO is not formally deprecated, but rather not preferred, with octal permissions generally recommended instead (see Documentation/dev-tools/checkpatch.rst[1]). Using wording closer to that might be more precise. [1] https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/tree/Documentation/dev-tools/checkpatch.rst#n1060 > > Signed-off-by: Jack Lee > --- > drivers/cpufreq/powernow-k6.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/powernow-k6.c b/drivers/cpufreq/powernow-k6.c > index 99d2244e03b0..764907b04c04 100644 > --- a/drivers/cpufreq/powernow-k6.c > +++ b/drivers/cpufreq/powernow-k6.c > @@ -29,10 +29,10 @@ static unsigned int max_multiplier; > static unsigned int param_busfreq = 0; > static unsigned int param_max_multiplier = 0; > > -module_param_named(max_multiplier, param_max_multiplier, uint, S_IRUGO); > +module_param_named(max_multiplier, param_max_multiplier, uint, 0444); > MODULE_PARM_DESC(max_multiplier, "Maximum multiplier (allowed values: 20 30 35 40 45 50 55 60)"); > > -module_param_named(bus_frequency, param_busfreq, uint, S_IRUGO); > +module_param_named(bus_frequency, param_busfreq, uint, 0444); > MODULE_PARM_DESC(bus_frequency, "Bus frequency in kHz"); > > /* Clock ratio multiplied by 10 - see table 27 in AMD#23446 */ -- Thx and BRs, Zhongqiu Han