From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966847AbcA1Me0 (ORCPT ); Thu, 28 Jan 2016 07:34:26 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:57962 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965838AbcA1MeY (ORCPT ); Thu, 28 Jan 2016 07:34:24 -0500 From: Arnd Bergmann To: Simon Horman Cc: Julian Anastasov , Wensong Zhang , linux-arm-kernel@lists.infradead.org, Pablo Neira Ayuso , Patrick McHardy , Jozsef Kadlecsik , "David S. Miller" , netdev@vger.kernel.org, lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] netfilter: ipvs: avoid unused variable warnings Date: Thu, 28 Jan 2016 13:28:17 +0100 Message-ID: <121171795.jNF1vkL58j@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160127233953.GB5183@verge.net.au> References: <1453902749-3422685-1-git-send-email-arnd@arndb.de> <20160127233953.GB5183@verge.net.au> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:bWavgdERN2bha0avfDz/FiKGvdOhmQCiSkA8Ls5fSQlxUJcDKMZ 6CgIoCzoTS3g0oR/9byIdcS+gwSQfjXVNLABlhawwQlQKNBeqcKxZsjVuI+TaqrdZVy5wD/ +h5wcCrcpijL7SoSYPn3kl0WmlTtuHV/1od/illC79su+snrSa2Hiq8zqUjnr9HD+MHHqKI OkvCyhxygCKbV/rRfuBwg== X-UI-Out-Filterresults: notjunk:1;V01:K0:X8gJSkfp61Q=:GL9rxovMsj4aXqsceCojMB G/KtubVEIu4PxW0FvFP1p1P/afPanh7wi75QCnbD635arQLUVq3liHTxZzaAb0iiBW7HIgdFq WDJTBwG3WGnwVsB6vkqfaSKWAWevG11csxAk9BNUKoGm/xdVP0u/EqlLc3ok8LY/Kiu9m+u+l RW4z467PcyAAfOgmsX5MHVJodCCxUCmOx+gcY3EAAKtpXFuetWWCEw8HXVvXE1Zei6ka/evCZ w8A8ArWhOEyhpq5Z4X6stQ3k6xz/EgtL7dKmkvuExR2kLVTYd+zDXr4x3k/CEMwEeGsxB/b3C 5iwJkXpETo2BiOf3CPQnk5oUOdH+l+scPFU8wMauYgct8MLPCqaELiKmFVoPqJnX+nXcISSi/ XgWRSqtwBlJqjrViIHd1oRQyzxdfK4JF2Rfc4dGqonwhcOeCGi5g8QCx0cN4bpRAukx9nROUT YbYMh+QohXKVTt+9Sgk/qIOGa3cOtARLF3g8gvtFJJhtsuPdf/dTSp/c6uFZEpUt1ZsXA7nHK qArtITOJuZKsfbL9k1fo6XhUgQODzK1AZO2H5yXxLRef/NWIG6YGYkutCicnsVi6Clf5KyBbi Pp0Svl1REWU40GN38Okt+WQ7tT5Cw2+SZ2z7VPq8KbvYJwpdQJbWzJBKjTaFqYNJP6GjzyEBL 740j3aQi1uGWhcTdIJzULZgcrbbkVYeMpdvAbLU9hkpWl9gDiRGNSK16To7Cxlb0J5FaveIPn kel1Tu9fASxOwr5g Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 28 January 2016 08:39:53 Simon Horman wrote: > On Wed, Jan 27, 2016 at 10:01:42PM +0200, Julian Anastasov wrote: > > > > Hello, > > > > On Wed, 27 Jan 2016, Arnd Bergmann wrote: > > > > > The proc_create() and remove_proc_entry() functions do not reference > > > their arguments when CONFIG_PROC_FS is disabled, so we get a couple > > > of warnings about unused variables in IPVS: > > > > > > ipvs/ip_vs_app.c:608:14: warning: unused variable 'net' [-Wunused-variable] > > > ipvs/ip_vs_ctl.c:3950:14: warning: unused variable 'net' [-Wunused-variable] > > > ipvs/ip_vs_ctl.c:3994:14: warning: unused variable 'net' [-Wunused-variable] > > > > > > This removes the local variables and instead looks them up separately > > > for each use, which obviously avoids the warning. > > > > > > Signed-off-by: Arnd Bergmann > > > Fixes: 4c50a8ce2b63 ("netfilter: ipvs: avoid unused variable warning") > > > > Looks like your previous patch for ip_vs_app_net_cleanup > > was delayed in ipvs-next tree. I guess, Simon should drop it and > > use this one instead when net-next opens: > > > > Acked-by: Julian Anastasov > > Thanks, and sorry about not pushing the other patch to net-next. > I have dropped it and queued up this one in its place. Ah, I had not realized that the other patch was still in ipvs-next and not merged in mainline. I did most of my testing on linux-next (with the previous patch) and then validated the new one on 4.5-rc1, which led me to update it to contain the same hunk again. Replacing the original patch works fine though, thanks for picking it up! Arnd