From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755346AbYEYOgr (ORCPT ); Sun, 25 May 2008 10:36:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753070AbYEYOgh (ORCPT ); Sun, 25 May 2008 10:36:37 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:37175 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752456AbYEYOgh (ORCPT ); Sun, 25 May 2008 10:36:37 -0400 Subject: Re: [PATCHv2 04/28] cx25840: treat firmware data as const From: David Woodhouse To: Hans Verkuil Cc: linux-kernel@vger.kernel.org, sam@ravnborg.org, alan@lxorguk.ukuu.org.uk, akpm@linux-foundation.org, Tyler Trafford , Mike Isely In-Reply-To: <200805251251.32373.hverkuil@xs4all.nl> References: <1211708969@pmac.infradead.org> <200805251251.32373.hverkuil@xs4all.nl> Content-Type: text/plain Date: Sun, 25 May 2008 15:36:31 +0100 Message-Id: <1211726191.31212.112.camel@shinybook.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 (2.22.1-2.fc9) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2008-05-25 at 12:51 +0200, Hans Verkuil wrote: > There is no need to do the first two bytes first. As far as I can tell > it was done to avoid having to allocate a local buffer. Thanks. I suspected as much, but wanted to err on the side of caution since I can't test it. I'll change it in the next iteration. -- dwmw2