mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: ksummit-2008-discuss@lists.linux-foundation.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [Ksummit-2008-discuss]  Fixing the Kernel Janitors project
Date: Wed, 28 May 2008 23:49:20 +0300	[thread overview]
Message-ID: <1212007760.2236.17.camel@shinybook.infradead.org> (raw)
In-Reply-To: <1211995212.3445.52.camel@localhost.localdomain>

On Wed, 2008-05-28 at 12:20 -0500, James Bottomley wrote:
> In the early days, the project was conceived as a way of getting fresh
> blood into kernel development by giving them fairly simple but generally
> useful tasks and hoping they'd move more into the mainstream.  If we
> wind forwards to 2008, there's considerable and rising friction being
> generated by janitorial patches.  This is only an example:
> 
> http://marc.info/?l=linux-kernel&m=121135889328760
> 
> but there are many more.

The example that sums it up for me is this one:

	http://lkml.org/lkml/2008/5/18/20

We have people making minor cosmetic changes, and not paying even the
_slightest_ attention to what they're doing. This one's a particularly
scary example because it's something even the most non-technical person
should have spotted; there's _no_ excuse. It's the cosmetic equivalent
of a naïve warning fix that leaves the actual bug in place.

I think you're right that the status quo is damaging, and I don't see it
getting any better with the current quality of 'janitoring'. I think the
only way we can salvage anything useful from the janitors project is to
keep a close rein on what tasks are actually undertaken.

But we've pushed back on people doing this kind of thing before, and
pointed them both at the obvious things they've missed in the context of
their patches, and other more useful things they could be doing -- but
we've often received responses along the lines of "but I don't want to
have to _think_!".

It's hard to know where to go from there, and it's not exactly
surprising that we end up frustrated.

-- 
dwmw2


  parent reply	other threads:[~2008-05-28 20:49 UTC|newest]

Thread overview: 109+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-28 17:20 James Bottomley
2008-05-28 17:43 ` H. Peter Anvin
2008-05-28 19:08 ` Rik van Riel
2008-05-28 20:15   ` Chris Mason
2008-05-29 10:34     ` Jiri Kosina
2008-05-31  8:38       ` Pavel Machek
2008-05-28 20:38   ` James Bottomley
2008-05-28 20:49 ` David Woodhouse [this message]
2008-05-28 21:01   ` James Bottomley
2008-05-28 21:31     ` Pekka Enberg
2008-05-28 21:42       ` James Bottomley
2008-05-28 22:18         ` David Woodhouse
2008-05-28 22:35           ` James Bottomley
2008-05-28 22:51             ` Greg KH
2008-05-28 23:23               ` Luck, Tony
2008-05-29  0:36                 ` Greg KH
2008-05-29  1:00                   ` Dave Jones
2008-05-29  2:26                     ` Greg KH
2008-05-30 20:23                       ` How many contributors are we losing Luck, Tony
2008-05-30 20:46                         ` Willy Tarreau
2008-05-30 20:47                         ` Greg KH
2008-05-30 23:37                           ` [Ksummit-2008-discuss] " Grant Grundler
2008-05-31 19:53                             ` Stefan Richter
2008-05-30 21:01                         ` [Ksummit-2008-discuss] " Daniel Walker
2008-05-30 21:13                         ` Hugh Dickins
2008-05-30 22:05                           ` Luck, Tony
2008-05-30 22:53                             ` Theodore Tso
2008-05-30 23:10                           ` H. Peter Anvin
2008-05-31  1:12                         ` Josh Boyer
2008-05-29  6:12               ` [Ksummit-2008-discuss] Fixing the Kernel Janitors project David Miller
2008-05-29  6:09             ` David Miller
2008-05-29 13:24               ` Peter Zijlstra
2008-05-29 14:36               ` James Bottomley
2008-05-29 15:06                 ` Jiri Kosina
2008-05-29 16:32                   ` Matthew Wilcox
2008-05-30  0:24                     ` Stefan Richter
2008-06-02 10:32                     ` Jiri Kosina
2008-06-02 10:43                       ` Rafael J. Wysocki
2008-05-29 17:37                   ` James Bottomley
2008-05-29 20:24                     ` Rafael J. Wysocki
2008-05-31 19:21                   ` Lars Noschinski
2008-06-01 16:09                     ` store-same-blocksonce (was Re: [Ksummit-2008-discuss] Fixing the Kernel Janitors project) Pavel Machek
2008-06-02  8:18               ` [Ksummit-2008-discuss] Fixing the Kernel Janitors project Paul Jackson
2008-05-29  2:27 ` Matthew Wilcox
2008-05-29  5:58 ` David Miller
2008-05-29  6:17   ` Benjamin Herrenschmidt
2008-05-29 12:45     ` Theodore Tso
2008-05-29 16:15       ` RFC: Moving firmware blobs out of the kernel David Woodhouse
2008-05-29 16:47         ` [Ksummit-2008-discuss] " Greg KH
2008-05-29 20:29           ` Arjan van de Ven
2008-05-29 20:47             ` Matthew Wilcox
2008-05-29 20:55               ` Yinghai Lu
2008-05-29 20:59                 ` James Bottomley
2008-05-29 21:03                 ` Greg KH
2008-05-30  9:20                   ` Alan Cox
2008-05-30 10:38                     ` David Woodhouse
2008-05-29 21:31                 ` David Miller
2008-05-29 21:57                   ` Yinghai Lu
2008-05-30  9:52                     ` Takashi Iwai
2008-05-30 10:37                       ` David Woodhouse
2008-05-29 21:09             ` David Miller
2008-05-29 21:11               ` Arjan van de Ven
2008-05-29 23:04                 ` David Woodhouse
2008-05-30 13:47                   ` Arnaldo Carvalho de Melo
2008-06-01 16:17                   ` Pavel Machek
2008-06-06 14:46                     ` David Woodhouse
2008-06-07  9:53                       ` Pavel Machek
2008-06-08 11:13                   ` Mauro Carvalho Chehab
2008-05-29 22:11               ` David Woodhouse
2008-05-30 18:37                 ` Grant Grundler
2008-06-07 22:14               ` Alexandre Oliva
2008-05-29 19:12         ` Jeff Garzik
2008-05-29 21:17           ` [Ksummit-2008-discuss] " Peter Zijlstra
2008-05-29 23:39             ` H. Peter Anvin
2008-05-30  9:31               ` Alan Cox
2008-05-30  9:50                 ` Peter Zijlstra
2008-05-30 13:53                   ` Jeff Garzik
2008-05-30 21:08                   ` Alexandre Oliva
2008-05-30 23:14                 ` H. Peter Anvin
2008-05-31 14:05                   ` Alan Cox
2008-05-31 15:10                     ` H. Peter Anvin
2008-05-30  1:27             ` Benjamin Herrenschmidt
2008-05-29 21:18           ` David Woodhouse
2008-05-30  1:22         ` Benjamin Herrenschmidt
2008-05-29 20:54       ` [Ksummit-2008-discuss] Fixing the Kernel Janitors project David Miller
2008-05-29 20:59         ` Matthew Wilcox
2008-05-29 21:12           ` Greg KH
2008-05-30  1:25           ` Benjamin Herrenschmidt
2008-05-30  2:20             ` Matthew Wilcox
2008-05-29 21:14         ` Theodore Tso
2008-05-29 21:39           ` David Miller
2008-06-01 14:11             ` Thomas Gleixner
2008-06-01 14:24               ` James Bottomley
2008-06-01 16:21                 ` s2ram video problems " Pavel Machek
2008-06-01 17:55                   ` Rafael J. Wysocki
2008-06-01 18:04                   ` James Bottomley
2008-06-01 18:14                     ` Rafael J. Wysocki
2008-06-01 18:14                     ` Matthew Garrett
2008-06-01 18:17               ` Matthew Garrett
2008-06-01 20:22                 ` Thomas Gleixner
2008-06-01 20:36                   ` Matthew Garrett
2008-06-01 23:56                   ` Benjamin Herrenschmidt
2008-05-30  1:20       ` Benjamin Herrenschmidt
2008-05-30  6:55         ` David Miller
2008-05-29 16:03     ` Jonathan Corbet
2008-05-30  0:40       ` Neil Brown
2008-05-29 14:26   ` James Bottomley
2008-05-29 11:32 ` Helge Hafting
2008-05-29 13:44 ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1212007760.2236.17.camel@shinybook.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=ksummit-2008-discuss@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®